crash with ic2 classic
Trinsdar opened this issue ยท 1 comments
so I ran this with ic2 classic and it crashed saying an int was being casted to a collection.
https://paste.dimdev.org/uroyejiqun.sql
minecraft 1.12.2
forge 14.23.5.2811
mfss 1.12 4.0.1
I'm guessing this line somehow doesn't work with ic2 classic?
Maybe an if loaded check should be added for that line that checks if ic2 classic is not loaded?
That's a bug in Classic's ropey API support. Recipes#matterAmplifier
is defined as a map from IRecipeInput
to Integer
s that is applied to ItemStack
s. Classic's BasicMachineRecipeList#toIC2Exp
raw casts an anonymous IBasicMachineRecipeManager
which is only really designed for IRecipeInput
to Collection<ItemStack>
(applied to ItemStack
s). For your macerator type machine that is fine as they're defined using that, but for any of the others this will result in class cast exceptions as Java isn't type checking if the casts are really valid until runtime.
MFFS should work fine otherwise as it is using the API correctly everywhere as far as I can tell.