Modular Golems

Modular Golems

2M Downloads

Performance doubts

baronpalmer opened this issue ยท 5 comments

commented

Hey, while doing some troubleshooting with spark I noticed very high performance usage from modular golems

Image

Is this suppose to be happening for every entity ??

commented

I just wrap it to check if it's ridden by golem. It just calls the actual traveling code. It won't actually cause any performance issue.

commented

The logic is: If the rider is golem, normalize the traveling vector (increase speed)

commented

I'm not familiar with the contents of the mod, i'm assuming entities other than the player can ride the golems?

commented

That makes sense, thank you for the insight

commented

It's that golem can ride mobs that are ridable by players, but mob riding and player riding has different calculation, so I need to scale the speed. Here I wrap the vanilla code for entity travelling. The performance cost you see are actually from vanilla behavior.