Modular Machinery: Community Edition

When I install another model via event.modelName = "name", the model does not change.

Most likely, the problem is that this condition is incorrect, it cannot be fulfilled with the correct model name:

ModularMachinery-Community-Edition/src/main/java/hellfirepvp/modularmachinery/common/tiles/base/TileMultiblockMachineController.java

Line 1318 in 946b217

if (modelName == null || modelName.isEmpty()) {

Is the model registered?

Is the model registered?

Yes, all the models I used were pre-registered via "GeoMachineModel.registerGeoMachineModel".

It still seems to me that this condition, which I noted above, should look something like this:
modelName != null && !modelName.isEmpty()

After all, it is not logical to try to get a model by an empty name or a null one.

ModularMachinery-Community-Edition/src/main/java/hellfirepvp/modularmachinery/common/tiles/base/TileMultiblockMachineController.java

Lines 1329 to 1333 in 946b217

    
           public String getCurrentModelName() { 
        
               ControllerModelGetEvent event = new ControllerModelGetEvent(this); 
        
               event.postEvent(); 
        
               return event.getModelName(); 
        
           }

The machine will first get the model via an event... It only goes back to get the default model if it returns an empty name.

holy shit... it will be fixed in pre6.

	public String getCurrentModelName() {
	ControllerModelGetEvent event = new ControllerModelGetEvent(this);
	event.postEvent();
	return event.getModelName();
	}

Share to