MES - Moog's End Structures

MC: 1.20.1
Forge: 47.3.7
Demo Seed: -5369739075177785926, Position: -4518 65 -11983

Tested with Waystones, Repurposed Structures and MES

Disabling waystone generation in villages stops working (for Repurposed Structures villages) if MES is installed, meaning waystones generate in villages even when disabled in the config.

This would mean that this condition is never checked when MES is installed.

Left: Without MES, Right: With MES

Not too sure but might have something to do with

MoogsEndStructures/common/src/main/java/com/finndog/mes/misc/pooladditions/PoolAdditionMerger.java

Line 39 in 4515b19

public final class PoolAdditionMerger {

, which uses the same concept as Repurposed Structures, but also uses the same pool_additions naming convention, causing a double-merger (one of which ignores the condition field).

They have since fixed this by using a unique name, instead of using pool_additions, however that change has yet to be released in 1.20.1.

They also state in their source code:

// NOTE: Anyone copying this class, PLEASE CHANGE THE BELOW STRING TO BE UNIQUE!!!!
// If you do not, both of our mods will read the same file twice and apply the file twice, causing duplicate additions to pools!!!

I might be able to draft a PR for this if this is actually what is causing this to happen.

Share to