More (Fishing) Rod Variants (MStV+)

More (Fishing) Rod Variants (MStV+)

11.2k Downloads

[ISSUE]: Model for the oak fishing rod (vanilla rod in default) deforms the texture if resource pack replacement is applied.

Dasawkem opened this issue · 4 comments

commented

Where did you encounter this issue?

Singleplayer

Mod Version

1.1.1 + 1.21.4(-6)

Minecraft Version

1.21.5

Minecraft Mod Loader

Fabric

Mod Loader Version

No response

Description

When texture of vanilla fishing rod is changed, instead of the expected texture change, the game instead loads the new texture on what appears to be a base model of vanilla fishing rods, instead of simply replacing the texture.

Note that this doesn't apply to the rods that the mod adds; their textures are replaced normally via texture packs, only the vanilla fishing rod seems to be oddly deformed this way.

Image
Image
Image
Image

Steps to Reproduce

  1. Use a resource pack that changes the visuals of the vanilla (oak) fishing rod, and view the item.
  2. If wanted, for comparison, use resource pack for added rods, to show that they seemingly function normally.

Logs

https://mclo.gs/RgYrlCR

Checklist

  • I have searched both open and closed issues for similar issues and I couldn't find anything.
commented

Thanks for the report, unfortunately I can't reproduce your issue on my end. Can you please provide the exact resource pack you're encountering the issue with? Are you not experiencing this issue when "More Fishing Rod Variants" isn't installed and only experience it when it is installed?

commented

Thanks for the report, unfortunately I can't reproduce your issue on my end. Can you please provide the exact resource pack you're encountering the issue with? Are you not experiencing this issue when "More Fishing Rod Variants" isn't installed and only experience it when it is installed?

I’m using just a basic sprite replacement resource pack, “Better Fishing Rod”, which is just a simple texture change with no model edits. It is an older pack so the sprite needs renaming to work in 1.21.5, but otherwise it’s just a standard sprite replacement pack. Anything I add in a pack that just changes the sprite also has the issue persist, regardless, but I figured I’d share the pack I got the sprites from anyways.

However I have not tried it on a world with no other mods besides More Fishing Rods (and its dependencies). Could definitely be some conflict, my suspicions are that it’s either Hold My Items or Not Enough Animations that’s possibly messing with it. Either that or it’s something in my personal mishmash of a resource pack, but I double checked and it doesn’t seem to change anything about the model of the vanilla rod so I don’t believe it’s resource pack related.

I will get back to you after some testing and report my findings!

commented

Update! Yup, it seems to function just fine on a vanilla world AND in a world with all my resource packs turned off minus adding sprite edits to the fishing rods.

Apologies for wasting your time, this appears to be a resource pack error on my end! I was so certain it wasn't, but I suppose I missed something. Have a good day!

commented

No problem, I absolutely understand where you were coming from, and I'm glad we were able to narrow down the issue a bit for you. ^^"