More Minecarts and Rails

More Minecarts and Rails

7M Downloads

Chunkrodite returned from breaking a chunk loader doesn't factor in the chunk loader multiplier

kevin-wackman opened this issue ยท 2 comments

commented

Hey there,

I bumped up the chunk_loader_multiplier in the config of a single-player world since I would prefer if chunk loading is fairly cheap, and noticed that chunkrodite is effectively duplicated by the multiplier if you fuel and break the chunkloader
Reproduction steps:

  • Change the chunk_loader_multiplier to a higher value (100x is the most extreme example).
  • Power a chunk loader with some crystal
  • Break the chunk loader, receive the chunkrodite it drops
  • Power the chunk loader with the dropped chunkrodite
  • Break the chunk loader again, observe that much more chunkrodite drops

This isn't a huge problem (and honestly the blocks make cool decoration), but it is 100% reproducible.
As far as a fix, I would assume adding a quick div by the multiplier in dropExtras() in ChunkLoaderTile.java should be enough to fix it, although I haven't tested it at all so take that with a grain of salt.

Let me know if you need any more information - I'm on 1.3.12, but it looks like this would happen across versions.

commented

Oh geez, you're right, that is a pretty major oversight. I'll try to patch this as soon as I can.

commented

This has been patched in the most recent version.