More Planets - Galacticraft Add-on

More Planets - Galacticraft Add-on

4M Downloads

Sound issues in Multiplayer

Manwil00 opened this issue ยท 4 comments

commented

More-Planets-1.12.2-2.0.21
Sounds of mobs added by the mod fail playing while being on a Multiplayer Server.
The following Report was generated after coming across a Cheese Floated but the same thing also happened with Alien Miners.

Notification by VanillaFix : https://paste.dimdev.org/xadagarema.mccrash

commented

Seems work fine to me, Cannot reproduce. (Multiplayer test)

2019-11-08_12 20 39

commented

I have had the Same issue, will investigate further later on.
But I think, it's because you check in your registerSounds() method, whether you are on a client, which doesn't make sense, because you have to register the sounds on the server as well.
If you don't register them on the Server, it can't resolve the Sound ID and then wrong packets get sent to the Client (specifically the Packet, which plays Vanilla Sounds). But because your Sounds aren't Vanilla Sounds - obviously - VanillaFix Shows the notification

commented

Oops, it seems missing RegistryEvent for SoundEvent.

commented

Fixed on both versions. 2.1.9 and 2.0.22.