More Villagers [Fabric]

More Villagers [Fabric]

8M Downloads

[Bug]: Frequent Customer advancement not achievable

Jigglypie opened this issue ยท 2 comments

commented

Mod Version

1.18.1

Mod Loader

Fabric

Mod Loader Version

0.12.12

What happened?

It appears that one of the traders does not count towards the 21 total trade requirements for the achievement "Frequent Customer." After replicating it in a singleplayer world with only More VIllagers loaded, it appears that the Miner trader is the one that does not count towards the achievement.

To confirm this is the case, I viewed all_professions_traded.json, and it does not seem that miner is mentioned anywhere, and only 20 total traders are in the code.

latest.log

[17:54:18] [main/INFO]: Loading Minecraft 1.18.1 with Fabric Loader 0.12.12
[17:54:18] [main/INFO]: Loading 52 mods:
- cloth-basic-math 0.6.0 via cloth-config
- cloth-config 6.1.48 via morevillagers-fabric
- fabric 0.46.4+1.18
- fabric-api-base 0.4.2+d7c144a865 via fabric
- fabric-api-lookup-api-v1 1.5.3+d7c144a865 via fabric
- fabric-biome-api-v1 6.0.2+d7c144a865 via fabric
- fabric-blockrenderlayer-v1 1.1.10+3ac43d9565 via fabric
- fabric-command-api-v1 1.1.7+d7c144a865 via fabric
- fabric-commands-v0 0.2.6+b4f4f6cd65 via fabric
- fabric-containers-v0 0.1.19+d7c144a865 via fabric
- fabric-content-registries-v0 0.4.8+d7c144a865 via fabric
- fabric-crash-report-info-v1 0.1.9+3ac43d9565 via fabric
- fabric-dimensions-v1 2.1.10+a1d9bbf565 via fabric
- fabric-entity-events-v1 1.4.6+d7c144a865 via fabric
- fabric-events-interaction-v0 0.4.17+d7c144a865 via fabric
- fabric-events-lifecycle-v0 0.2.9+d7c144a865 via fabric
- fabric-game-rule-api-v1 1.0.11+d7c144a865 via fabric
- fabric-item-api-v1 1.3.1+691a79b565 via fabric
- fabric-item-groups-v0 0.3.6+3ac43d9565 via fabric
- fabric-key-binding-api-v1 1.0.9+d7c144a865 via fabric
- fabric-keybindings-v0 0.2.7+b4f4f6cd65 via fabric
- fabric-lifecycle-events-v1 1.4.13+713c266865 via fabric
- fabric-loot-tables-v1 1.0.9+d7c144a865 via fabric
- fabric-mining-level-api-v1 1.0.6+d7c144a865 via fabric
- fabric-mining-levels-v0 0.1.11+b4f4f6cd65 via fabric
- fabric-models-v0 0.3.4+d7c144a865 via fabric
- fabric-networking-api-v1 1.0.19+d7c144a865 via fabric
- fabric-networking-v0 0.3.6+b4f4f6cd65 via fabric
- fabric-object-builder-api-v1 1.11.4+d7c144a865 via fabric
- fabric-object-builders-v0 0.7.12+d7c144a865 via fabric
- fabric-particles-v1 0.2.10+526dc1ac65 via fabric
- fabric-registry-sync-v0 0.9.2+ad01bfbd65 via fabric
- fabric-renderer-api-v1 0.4.11+b0b66fc365 via fabric
- fabric-renderer-indigo 0.4.15+6825030165 via fabric
- fabric-renderer-registries-v1 3.2.10+b4f4f6cd65 via fabric
- fabric-rendering-data-attachment-v1 0.3.5+d7c144a865 via fabric
- fabric-rendering-fluids-v1 0.1.19+3ac43d9565 via fabric
- fabric-rendering-v0 1.1.12+b4f4f6cd65 via fabric
- fabric-rendering-v1 1.10.6+713c266865 via fabric
- fabric-resource-conditions-api-v1 1.0.2+d7c144a865 via fabric
- fabric-resource-loader-v0 0.4.14+713c266865 via fabric
- fabric-screen-api-v1 1.0.8+d7c144a865 via fabric
- fabric-screen-handler-api-v1 1.1.12+d7c144a865 via fabric
- fabric-structure-api-v1 2.1.3+d7c144a865 via fabric
- fabric-tag-extensions-v0 1.2.8+d7c144a865 via fabric
- fabric-textures-v0 1.0.10+3ac43d9565 via fabric
- fabric-tool-attribute-api-v1 1.3.8+fb3b57b465 via fabric
- fabric-transfer-api-v1 1.5.9+d7c144a865 via fabric
- fabricloader 0.12.12
- java 17
- minecraft 1.18.1
- morevillagers-fabric 3.1.1-SNAPSHOT
[17:54:19] [main/INFO]: SpongePowered MIXIN Subsystem Version=0.8.4 Source=file:/C:/Users/Josh/curseforge/minecraft/Install/libraries/net/fabricmc/sponge-mixin/0.10.7+mixin.0.8.4/sponge-mixin-0.10.7+mixin.0.8.4.jar Service=Knot/Fabric Env=CLIENT
[17:54:19] [main/INFO]: Compatibility level set to JAVA_16
[17:54:23] [main/WARN]: @Inject(@at("INVOKE")) Shift.BY=3 on fabric-lifecycle-events-v1.mixins.json:client.WorldChunkMixin::handler$zdg000$onLoadBlockEntity exceeds the maximum allowed value: 0. Increase the value of maxShiftBy to suppress this warning.
[17:54:27] [Render thread/INFO]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD'
[17:54:28] [Render thread/INFO]: Setting user: Jiggilypie
[17:54:31] [Render thread/INFO]: [Indigo] Registering Indigo renderer!
[17:54:32] [Render thread/INFO]: Backend library: LWJGL version 3.2.2 build 10
[17:54:35] [Render thread/INFO]: Narrator library for x64 successfully loaded
[17:54:35] [Render thread/INFO]: Reloading ResourceManager: Default, Fabric Mods (Cloth Config v6, Fabric API, Fabric API Base, Fabric API Lookup API (v1), Fabric Biome API (v1), Fabric BlockRenderLayer Registration (v1), Fabric Command API (v1), Fabric Commands (v0), Fabric Containers (v0), Fabric Content Registries (v0), Fabric Crash Report Info (v1), Fabric Dimensions API (v1), Fabric Entity Events (v1), Fabric Events Interaction (v0), Fabric Events Lifecycle (v0), Fabric Game Rule API (v1), Fabric Item API (v1), Fabric Item Groups (v0), Fabric Key Binding API (v1), Fabric Key Bindings (v0), Fabric Lifecycle Events (v1), Fabric Loot Tables (v1), Fabric Mining Level API (v1), Fabric Mining Levels (v0), Fabric Models (v0), Fabric Networking API (v1), Fabric Networking (v0), Fabric Object Builder API (v1), Fabric Object Builders (v0), Fabric Particles (v1), Fabric Registry Sync (v0), Fabric Renderer API (v1), Fabric Renderer - Indigo, Fabric Renderer Registries (v1), Fabric Rendering Data Attachment (v1), Fabric Rendering Fluids (v1), Fabric Rendering (v0), Fabric Rendering (v1), Fabric Resource Conditions API (v1), Fabric Resource Loader (v0), Fabric Screen API (v1), Fabric Screen Handler API (v1), Fabric Structure API (v1), Fabric Tag Extensions (v0), Fabric Textures (v0), Fabric Tool Attribute API (v1), Fabric Transfer API (v1), Fabric Loader, MoreVillagersFabric)
[17:54:40] [Render thread/INFO]: OpenAL initialized on device OpenAL Soft on Speakers (Realtek High Definition Audio)
[17:54:40] [Render thread/INFO]: Sound engine started
[17:54:40] [Render thread/INFO]: Created: 1024x1024x4 minecraft:textures/atlas/blocks.png-atlas
[17:54:40] [Render thread/INFO]: Created: 256x128x4 minecraft:textures/atlas/signs.png-atlas
[17:54:40] [Render thread/INFO]: Created: 1024x512x4 minecraft:textures/atlas/banner_patterns.png-atlas
[17:54:40] [Render thread/INFO]: Created: 1024x512x4 minecraft:textures/atlas/shield_patterns.png-atlas
[17:54:40] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/chest.png-atlas
[17:54:40] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/beds.png-atlas
[17:54:40] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/shulker_boxes.png-atlas
[17:54:42] [Render thread/INFO]: Created: 256x256x0 minecraft:textures/atlas/particles.png-atlas
[17:54:42] [Render thread/INFO]: Created: 256x256x0 minecraft:textures/atlas/paintings.png-atlas
[17:54:42] [Render thread/INFO]: Created: 256x128x0 minecraft:textures/atlas/mob_effects.png-atlas
[17:55:08] [Render thread/WARN]: Ambiguity between arguments [teleport, location] and [teleport, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[17:55:08] [Render thread/WARN]: Ambiguity between arguments [teleport, location] and [teleport, targets] with inputs: [0.1 -0.5 .9, 0 0 0]
[17:55:08] [Render thread/WARN]: Ambiguity between arguments [teleport, destination] and [teleport, targets] with inputs: [Player, 0123, @e, dd12be42-52a9-4a91-a8a1-11c01849e498]
[17:55:08] [Render thread/WARN]: Ambiguity between arguments [teleport, targets] and [teleport, destination] with inputs: [Player, 0123, dd12be42-52a9-4a91-a8a1-11c01849e498]
[17:55:08] [Render thread/WARN]: Ambiguity between arguments [teleport, targets, location] and [teleport, targets, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[17:55:08] [Render thread/INFO]: Reloading ResourceManager: Default, Fabric Mods (Fabric Tool Attribute API (v1), MoreVillagersFabric)
[17:55:08] [Render thread/INFO]: Loaded 7 recipes
[17:55:09] [Render thread/INFO]: Loaded 1157 advancements
[17:55:09] [Render thread/INFO]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD'
[17:55:09] [Render thread/INFO]: Applied 0 biome modifications to 0 of 61 new biomes in 5.209 ms
[17:55:09] [Server thread/INFO]: Starting integrated minecraft server version 1.18.1
[17:55:09] [Server thread/INFO]: Generating keypair
[17:55:14] [Server thread/INFO]: Preparing start region for dimension minecraft:overworld
[17:55:14] [Render thread/INFO]: Preparing spawn area: 0%
[17:55:14] [Render thread/INFO]: Preparing spawn area: 0%
[17:55:15] [Render thread/INFO]: Preparing spawn area: 0%
[17:55:15] [Render thread/INFO]: Preparing spawn area: 0%
[17:55:16] [Render thread/INFO]: Preparing spawn area: 1%
[17:55:16] [Render thread/INFO]: Preparing spawn area: 1%
[17:55:17] [Render thread/INFO]: Preparing spawn area: 3%
[17:55:17] [Render thread/INFO]: Preparing spawn area: 4%
[17:55:18] [Render thread/INFO]: Preparing spawn area: 6%
[17:55:18] [Render thread/INFO]: Preparing spawn area: 8%
[17:55:19] [Render thread/INFO]: Preparing spawn area: 10%
[17:55:19] [Render thread/INFO]: Preparing spawn area: 12%
[17:55:20] [Render thread/INFO]: Preparing spawn area: 15%
[17:55:20] [Render thread/INFO]: Preparing spawn area: 16%
[17:55:21] [Render thread/INFO]: Preparing spawn area: 19%
[17:55:21] [Render thread/INFO]: Preparing spawn area: 20%
[17:55:22] [Render thread/INFO]: Preparing spawn area: 23%
[17:55:22] [Render thread/INFO]: Preparing spawn area: 26%
[17:55:23] [Render thread/INFO]: Preparing spawn area: 28%
[17:55:23] [Render thread/INFO]: Preparing spawn area: 31%
[17:55:24] [Render thread/INFO]: Preparing spawn area: 33%
[17:55:24] [Render thread/INFO]: Preparing spawn area: 36%
[17:55:25] [Render thread/INFO]: Preparing spawn area: 39%
[17:55:25] [Render thread/INFO]: Preparing spawn area: 42%
[17:55:26] [Render thread/INFO]: Preparing spawn area: 44%
[17:55:26] [Render thread/INFO]: Preparing spawn area: 47%
[17:55:27] [Render thread/INFO]: Preparing spawn area: 49%
[17:55:27] [Render thread/INFO]: Preparing spawn area: 51%
[17:55:28] [Render thread/INFO]: Preparing spawn area: 54%
[17:55:28] [Render thread/INFO]: Preparing spawn area: 57%
[17:55:29] [Render thread/INFO]: Preparing spawn area: 59%
[17:55:29] [Render thread/INFO]: Preparing spawn area: 61%
[17:55:30] [Render thread/INFO]: Preparing spawn area: 63%
[17:55:30] [Render thread/INFO]: Preparing spawn area: 69%
[17:55:31] [Render thread/INFO]: Preparing spawn area: 71%
[17:55:31] [Render thread/INFO]: Preparing spawn area: 76%
[17:55:32] [Render thread/INFO]: Preparing spawn area: 78%
[17:55:32] [Render thread/INFO]: Preparing spawn area: 82%
[17:55:33] [Render thread/INFO]: Preparing spawn area: 84%
[17:55:33] [Render thread/INFO]: Preparing spawn area: 87%
[17:55:34] [Render thread/INFO]: Preparing spawn area: 91%
[17:55:34] [Render thread/INFO]: Preparing spawn area: 95%
[17:55:35] [Render thread/INFO]: Preparing spawn area: 99%
[17:55:35] [Render thread/INFO]: Time elapsed: 21067 ms
[17:55:35] [Server thread/INFO]: Changing simulation distance to 7, from 0
[17:55:35] [Server thread/INFO]: Jiggilypie[local:E:ce775ce1] logged in with entity id 145 at (-213.5, 64.0, -86.5)
[17:55:35] [Server thread/INFO]: Jiggilypie joined the game
[17:55:36] [Render thread/INFO]: Loaded 12 advancements
[17:55:44] [Render thread/INFO]: Loaded 14 advancements
[17:55:47] [Server thread/INFO]: Jiggilypie has made the advancement [Let's Get To Work]
[17:55:47] [Render thread/INFO]: [CHAT] Jiggilypie has made the advancement [Let's Get To Work]
[17:55:47] [Render thread/INFO]: Loaded 14 advancements
[17:55:57] [Server thread/INFO]: Jiggilypie has made the advancement [First Trade]
[17:55:57] [Server thread/INFO]: Jiggilypie has made the advancement [What a Deal!]
[17:55:57] [Render thread/INFO]: [CHAT] Jiggilypie has made the advancement [First Trade]
[17:55:57] [Render thread/INFO]: [CHAT] Jiggilypie has made the advancement [What a Deal!]
[17:55:57] [Render thread/INFO]: Loaded 20 advancements
[17:55:58] [Server thread/INFO]: Saving and pausing game...
[17:55:58] [Server thread/INFO]: Saving chunks for level 'ServerLevel[More Villager mod debugging]'/minecraft:overworld
[17:55:58] [Server thread/INFO]: Saving chunks for level 'ServerLevel[More Villager mod debugging]'/minecraft:the_nether
[17:55:58] [Server thread/INFO]: Saving chunks for level 'ServerLevel[More Villager mod debugging]'/minecraft:the_end
[17:56:09] [Server thread/INFO]: Saving and pausing game...
[17:56:09] [Server thread/INFO]: Saving chunks for level 'ServerLevel[More Villager mod debugging]'/minecraft:overworld
[17:56:09] [Server thread/INFO]: Saving chunks for level 'ServerLevel[More Villager mod debugging]'/minecraft:the_nether
[17:56:09] [Server thread/INFO]: Saving chunks for level 'ServerLevel[More Villager mod debugging]'/minecraft:the_end
[17:56:09] [Server thread/INFO]: Jiggilypie lost connection: Disconnected
[17:56:09] [Server thread/INFO]: Jiggilypie left the game
[17:56:09] [Server thread/INFO]: Stopping singleplayer server as player logged out
[17:56:09] [Server thread/INFO]: Stopping server
[17:56:09] [Server thread/INFO]: Saving players
[17:56:09] [Server thread/INFO]: Saving worlds
[17:56:09] [Server thread/INFO]: Saving chunks for level 'ServerLevel[More Villager mod debugging]'/minecraft:overworld
[17:56:38] [Server thread/INFO]: Saving chunks for level 'ServerLevel[More Villager mod debugging]'/minecraft:the_nether
[17:56:38] [Server thread/INFO]: Saving chunks for level 'ServerLevel[More Villager mod debugging]'/minecraft:the_end
[17:56:38] [Server thread/INFO]: ThreadedAnvilChunkStorage (More Villager mod debugging): All chunks are saved
[17:56:38] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM-1): All chunks are saved
[17:56:38] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM1): All chunks are saved
[17:56:38] [Server thread/INFO]: ThreadedAnvilChunkStorage: All dimensions are saved
[17:56:42] [Render thread/INFO]: Stopping!

commented

@PhoenixVX it is because the miner's namespace in all_professions_traded.json is morevillagers:miner when it should be minecraft:miner, like all the others are. This is only a fabric inconsistency.

commented

Closing as this should be fixed in:
3c13f93

Re-open if the issue still occurs, please and thanks!