Crash with ModernFix
Madis0 opened this issue ยท 7 comments
Just clicked "Reset cache" on the settings of MoreCulling v0.21.0
https://mclo.gs/cK9iGX2
This occurs because the fake block model map used when ModernFix's dynamic model loading is enabled doesn't really expose the concept of a "list of loaded models". I can prevent this from crashing but there's no guarantee it will have the correct functionality.
@embeddedt Is there any way to solve this from MoreCulling's side?
Also can't you get a list of all dynamic models that you've loaded so far. As that would solve any functionality issues I get from your fix, and this doesn't get called often so it doesn't need to be fast.
Tracking which models are block models and which models are item models is quite inconvenient; also because I don't hold permanent strong references to models, there's no guarantee such a list would really contain every model that's currently in use.
Ya makes sense. Once I have time ill check how your implementation works and attempt a workaround.
Your fix shouldn't cause any functionality issues atm other than cache resetting. I think.
Fixed in v0.22.0