CIT - Item frame remove CIT when using custom item renderer
Agent00Ming opened this issue ยท 34 comments
The new item frame culling breaks custom item textures that require an item's NBT data. This affects users of 'CIT Resewn' and possibly 'Chime' as well. Chime's custom item models work as intended
I am aware that this is a very niche case and it would be nice if it was possible to add options for culling. Versions 0.5.0+ can be configured
Below is an example of what happens when I put a diamond pickaxe that has a custom item texture based on an enchantment applied to it and the exact same pickaxe in the item frame.
@NovaXCIV What do you mean by that?
@NovaXCIV What do you mean by that?
This sword has a custom texture with the CIT feature of Optifine. If I put it in an item frame, it is shown as a default one. Same thing for every item with CIT
Ya so I've identified the problem. I will release MoreCulling v0.5.0 today which comes with the ability to toggle each optimization.
Its a temporary fix while I write a compatibility for CIT
You can use any CIT texture. Example: https://www.planetminecraft.com/texture-pack/centurion-pack/
I haven't had the time to work on this. Although currently in v0.5.0, you can disable the custom item frame renderer, which should fix your issue
@NovaXCIV All the CIT packs I've tried don't work. I'm guessing the 1.19 version is not fully supported. I'm only working on 1.19 at the moment
Edit to the original issue: Chime resource packs are unaffected. I have tested with default configs on 0.5.0 and 0.5.1.
make sure you are using cit resewn, cit does work perfectly in 1.19
Yup, I was using cit resewn. Can someone give me a pack they have actually tested with instructions on how to recreate? I've never touched cit before, plus I'm too busy to check xD
https://www.curseforge.com/minecraft/texture-packs/library-9366/download/3861999
This is the pack I originally had issues with and still do when turning on custom item frame renderer.
https://www.curseforge.com/minecraft/texture-packs/library-9366/download/3861999 This is the pack I originally had issues with and still do when turning on custom item frame renderer.
So how do I use it. I asked for steps to recreate
Look for 'enchanted book' in the creative inventory when the pack is active and it should show a bunch of different textures.
If that isn't the case then the issue lies in the CITs not even loading.
Might be: SHsuperCM/CITResewn#176
[main/INFO]: Loading 57 mods:
- citresewn 1.1.1+1.19
- citresewn-defaults 1.1.1+1.19 via citresewn
- cloth-basic-math 0.6.1 via cloth-config
- cloth-config 7.0.73 via moreculling
- conditional-mixin 0.3.0 via moreculling
- fabric 0.58.0+1.19
- fabric-api-base 0.4.9+e62f51a3a9 via fabric
- fabric-api-lookup-api-v1 1.6.7+9ff28f40a9 via fabric
- fabric-biome-api-v1 9.0.14+b2a4a624a9 via fabric
- fabric-blockrenderlayer-v1 1.1.18+9ff28f40a9 via fabric
- fabric-command-api-v1 1.2.6+f71b366fa9 via fabric
- fabric-command-api-v2 2.1.2+0d55f585a9 via fabric
- fabric-commands-v0 0.2.23+df3654b3a9 via fabric
- fabric-containers-v0 0.1.28+df3654b3a9 via fabric
- fabric-content-registries-v0 3.2.1+07df213ea9 via fabric
- fabric-convention-tags-v1 1.0.8+37622d24a9 via fabric
- fabric-crash-report-info-v1 0.2.3+bd0a0d4aa9 via fabric
- fabric-data-generation-api-v1 5.1.2+a680b9b4a9 via fabric
- fabric-dimensions-v1 2.1.28+a6d2f785a9 via fabric
- fabric-entity-events-v1 1.4.16+9ff28f40a9 via fabric
- fabric-events-interaction-v0 0.4.26+9ff28f40a9 via fabric
- fabric-events-lifecycle-v0 0.2.26+df3654b3a9 via fabric
- fabric-game-rule-api-v1 1.0.19+18990361a9 via fabric
- fabric-item-api-v1 1.5.5+35a03c43a9 via fabric
- fabric-item-groups-v0 0.3.26+9ff28f40a9 via fabric
- fabric-key-binding-api-v1 1.0.18+9ff28f40a9 via fabric
- fabric-keybindings-v0 0.2.16+df3654b3a9 via fabric
- fabric-lifecycle-events-v1 2.1.0+33fbc738a9 via fabric
- fabric-loot-api-v2 1.1.1+03a4e568a9 via fabric
- fabric-loot-tables-v1 1.1.4+9e7660c6a9 via fabric
- fabric-message-api-v1 1.0.1+513f4a59a9 via fabric
- fabric-mining-level-api-v1 2.1.11+33fbc738a9 via fabric
- fabric-models-v0 0.3.15+9ff28f40a9 via fabric
- fabric-networking-api-v1 1.1.0+442de8b8a9 via fabric
- fabric-networking-v0 0.3.15+df3654b3a9 via fabric
- fabric-object-builder-api-v1 4.0.8+9ff28f40a9 via fabric
- fabric-particles-v1 1.0.8+dc39553aa9 via fabric
- fabric-registry-sync-v0 0.9.18+23c4cfefa9 via fabric
- fabric-renderer-api-v1 1.0.8+9ff28f40a9 via fabric
- fabric-renderer-indigo 0.6.10+5187d39fa9 via fabric
- fabric-renderer-registries-v1 3.2.18+df3654b3a9 via fabric
- fabric-rendering-data-attachment-v1 0.3.12+9ff28f40a9 via fabric
- fabric-rendering-fluids-v1 3.0.5+9ff28f40a9 via fabric
- fabric-rendering-v0 1.1.20+df3654b3a9 via fabric
- fabric-rendering-v1 1.10.14+9ff28f40a9 via fabric
- fabric-resource-conditions-api-v1 2.0.9+e62f51a3a9 via fabric
- fabric-resource-loader-v0 0.5.6+5f1a85e0a9 via fabric
- fabric-screen-api-v1 1.0.24+f05effafa9 via fabric
- fabric-screen-handler-api-v1 1.2.7+9ff28f40a9 via fabric
- fabric-textures-v0 1.0.18+9ff28f40a9 via fabric
- fabric-transfer-api-v1 2.0.9+e62f51a3a9 via fabric
- fabric-transitive-access-wideners-v1 1.1.1+9e7660c6a9 via fabric
- fabricloader 0.14.8
- java 18
- minecraft 1.19
- modmenu 4.0.4
- moreculling 1.19-0.6.0
Next time opening a issue, please take a time to reproduce the bug for providing details or at least send the log file at the beginning. So that would be less exhausting for the developer and people who subscribed to this issue.
Haven't been able to reproduce so instead I told them how to fix it.
SHsuperCM/CITResewn#181
I can confirm this, easier to test is put custom texture of potion and compare it the item texture with the one on frame, on frame return to vanilla potion texture.
On Inventory (xali Potion):
When Dropped (with Interactic):
When on Frame (return to vanilla), we can compare it with WTHIT displayed icon (i draw red line):