MoreCulling

MoreCulling

Mods
77.1k Downloads

End Gateway and some BlockState culling are not working (earlier versions require Sodium)

yumunet opened this issue · 1 comments

commented

The following 4 culls are not working in latest 0.27.1.

  • End Gateway
  • BlockState Culling (the following three. Maybe not all)
    • Top of fence
    • Chorus plant
    • Bamboo

Also, these culls don't work without Sodium in 0.26.0 or earlier.
"End Gateway" and "Top of fence" in 0.23.1 to 0.26.0.
"Chorus plant" and "Bamboo" after in 0.21.0 to 0.26.0.

In 0.13.0 to 0.20.3, BlockState culling doesn't work with Fabric API, but it works when Sodium is added there. (the end gateway culling is unimplemented in this version)
Since 0.21.0 or later, FabricAPI is required, so it is incompatible with the IndigoRendrer?

Test

I have actually checked in each version.

World:

0.27.1

1.21.1, Fabric Loader 0.16.5 (Mods: Cloth Config 15.0.140, Fabric API 0.104.0, Mod Menu 11.0.2, Placeholder API 2.4.1)

All four aren't culled (even with Sodium 0.6.0 beta1 or beta2).

End Gateway:

Top of fence:

Chorus plant:

Bamboo:

0.26.0

1.21.1 (Same instance as above)

They don't work as it is, but they work with Sodium 0.5.11.

End Gateway:

Top of fence:

Chorus plant:

Bamboo:

0.23.1

1.20.4, Fabric Loader 0.16.5 (Mods: Cloth Config 13.0.138, Fabric API 0.97.2, Mod Menu 9.2.0, Placeholder API 2.4.0 pre1)

They work with Sodium 0.5.8. (Not without Sodium)

0.22.1

1.20.4 (Same instance as above)

"End Gateway" and "Top of fence" are culled without Sodium, but "Chorus plant" and "Bamboo" culling require Sodium 0.5.8.

0.21.0

1.20.4 (Same instance as above)

Exactly the same as above.

0.20.3

1.20.4 (Same instance as above)

(The "End Gateway" culling isn't yet implemented in this version.
Also, top of fence with flower pots on top isn't culled, but that is fixed in 0.21.0.)

"Top of fence" (with pressure plate) and "Chorus plant" and "Bamboo" aren't culled because of the Fabric API, but they are culled when Sodium 0.5.8 is added there.

They also work without the Fabric API.
By the way, they work without the Fabric API and with Sodium 0.5.8.

0.13.0

1.19.3, Fabric Loader 0.16.5 (Mods: Cloth Config 9.1.104, Fabric API 0.76.1)

Exactly the same as above. (Sodium 0.4.9)

0.12.5

1.19.3 (Same instance as above)

They work with Fabric API. (Even with Sodium)

commented

Wow, thanks. This should help a lot once I find time, or maybe @1foxy2 can look at it.

  • 👀1