Leaves Culling still actives where it shouldn't with specific resource packs on servers
NaiNonTH opened this issue · 12 comments
I use the Fancy leaves option (transparent leaves) with a Bushy Leaves for Faithful 32x, which I made, and a resource pack which I'm developing and it shows some kind of like an x-ray effect behind leaves blocks because those faces are hidden, giving such odd-looking as this screenshot provides—looks more obvious with leaves blocks on the floor.
It seems like it only happens on servers, and I'm not sure why this happens, but I think it's because of the modeling method that I'm using with those resource packs. If you don't mind, can you take a look at the code?
Sample: Bushy Leaves for Faithful 32x V1.1.zip
This has now been fixed internally, although I want to rewrite a good portion of how warped/container models are handled in order to bring much more performance while not limited the checks
Ah good. This is because its now a multipart baked model.
Thanks for reporting this, currently multipart block models that are transparent are not supported. Although this will help me make them supported.
There's a couple things about Multiparts that make them hard to handle currently.
Firstly multiparts can be based on the blockstate, which my system does not currently account for. Also if one part of the multipart is considered transparent I need to consider all parts transparent.
I thought my system would work with multiparts correctly due to them never being used directly although this obviously proves im wrong.
I will work on including blockstates with the system directly. It's something on my todo list anyways since its going to increase performance for blocks that have multiple block states where some are transparent
Fixed in Dev branch, expect this to be fixed when v0.8.0 comes out.
Although it would be nice if you could test this version also: https://github.com/fxmorin/MoreCulling/suites/7568491709/artifacts/312834638
Anyway, from this issue, I think it would be a pretty good idea to add a force culling for those who like using opaque leaves, which doesn't affect the look of the overall trees while gaining a significant performance improvement for fast leaves.
It already is forced ;)
If you are using fast rendering, I cull the leaves with fast.
No reason to add an option for unnoticeable improvements
Well, the "Force Leaves Culling" I meant is that block faces behind the leaves will also be hidden as well. I think that would improve such performance.
Well, the "Force Leaves Culling" I meant is that block faces behind the leaves will also be hidden as well. I think that would improve such performance.
When leaves are opaque, all block faces for leaves are culled, I believe this is the force culling you are talking about.
Ah well, I mean to cull the other block faces that are facing the leaves.
Oh thats actually a really good idea. That's right, leaves are considered not opaque and possibly transparent so blocks behind it are not culled. Ok I can definitely add that to the mod, thanks
