Fix MC-248964
muzikbike opened this issue · 5 comments
The bug (https://bugs.mojang.com/browse/MC-248964) concerns sugar cane with custom models not culling against each other, although other non-solid plant blocks like tall grass would also likely be affected if given such models.
The resource pack for testing this can be found attached to the ticket.
After testing ever single non colliding block in the game. Seems my system no longer needs that check, with all the code I've written its all taken care of. So this will probably increase performance for some blocks and also fix this bug and all other bugs related to non colliding blocks like rails.
I'm probably going to publish this in the beginning of January tho since I wont be home till than
Have you tested and checked that it does not work using MoreCulling, if so can you include the resource pack
I just remembered that my culling technique is written so that blocks without collisions don't get affected.
I think the system has progressed enough that I can remove that condition. I'll check that when I have some time
Alright so we are one step closer to fixing this bug. In v0.12.5 I made it possible for none colliding blocks to cull.
Had a couple bugs in it that got fixed in v0.13.0, although this still does not work.
Only difference between the two are the AbstractBlockSettings: collidable & opaque
This makes sense since opaque basically bypasses all my extra checks, so I have two options:
- Add a new tag within resourcepacks that people can use to declare a model as opaque internally so I can skip a whole load of work.
- Run complicated equations to determine the model's size, translucency, and transformations and than attempt to do a complicated match against the other sugar cane.
So ill probably just add a new tag
Edit:
I may actually try seeing if its possible to override the cull shape using a generated one based on the model. This would only be created when using a custom model, it would fix a couple of bugs although its also pretty expensive