MoreJS

MoreJS

Mods
8M Downloads

Unable to remove trades from mod `supplementaries`

LTCatt opened this issue ยท 3 comments

commented

Minecraft Version

1.20.1

Mod Version

0.9.0

Describe the bug!

I modified wanderer trades using the following code, but the supplementaries injected trades still comes up in morejs 0.9.0.

MoreJSEvents.wandererTrades(event => {
    event.removeVanillaTrades(1);
    event.removeVanillaTrades(2);
    event.removeModdedTrades(1);
    event.removeModdedTrades(2);
    event.addTrade(1, ['3x kubejs:ruby'], '6x minecraft:emerald').maxUses(3);
    event.addTrade(1, ['3x kubejs:amethyst'], '6x kubejs:ruby').maxUses(3);
    event.addTrade(2, ['6x minecraft:emerald'], '2x kubejs:ruby').maxUses(3);
    event.addTrade(2, ['6x kubejs:ruby'], '2x kubejs:amethyst').maxUses(3);
});

image

Crash Report

No response

Log

No response

Additions and Modifications

No

Additions and Modifications Description

No response

Did the issue happen in singleplayer or on a server?

Singleplayer

commented

Interesting, will try it. Probably a load order issue. Need to check how easy I can fix it

commented

I looked into it a bit more. Must execute /reload first, then summon a wandering trader. I don't know why :/

commented

Hey,
when installing supplementaries, there are no extra trades for me with the wanderer. Do I miss something?