MoreJS

MoreJS

Mods
8M Downloads

Change villagerTrades to startup event, otherwise in the server, the recipe viewer cannot display the modified trades

LTCatt opened this issue ยท 3 comments

commented

Minecraft Version

1.20.1

Mod Version

0.10.1

Describe the bug!

The EMI Trades and similar plugins only read VillagerTrades.TRADES.
When using MoreJS on a server, it only modifies this variable on the server side, but does not modify it on the client. As a result, when viewing trades using plugins on the client side, the modified trades will not be displayed.

Crash Report

No response

Log

No response

Additions and Modifications

Yes

Additions and Modifications Description

No response

Did the issue happen in singleplayer or on a server?

Server

commented

Not gonna do it. Minecraft itself handles trades server side.

commented

But then, is there a way to compatible with recipe viewers?

commented

The recipe viewer needs to handle it on server and sync it. That is what EMI Loot does for loot tables as an example. Every mod could modify trades on server, they should not rely on client information.