Morph-o-Tool

Morph-o-Tool

45M Downloads

unable to put both storage drawers keys inside tool

benbenlaw opened this issue ยท 10 comments

commented

added both items to the config, it only lets me put in one or the other not both any ideas?

commented

That would make sense as the morphing tool morphes into a mod wrench when it recognizes the mod from the block you hover over. If you have two of the same mod, it wouldn't know which one to use.

commented

From the perspective of the tool morphing into the item when looking at blocks from the item's mod, it is understandable that having more than one item in the tool from the same mod would be confusing to the tool. But this is a serious limition.

Is there no way to get around this?

commented

If this is still relevant in the newest version, please reopen the issue

commented

It is still an issue, however, we've added a keyring item to the Storage Drawers mod that can group all the keys into one item that allows you to switch between them at will. It is perfectly possible to add this keyring to the morphing tool instead of the keys.

The keyring was designed to be supported by the morphing tool, and it works really well on our end. However, because the keyring supports adding and removing keys at any time, it is now visible that the morphing tool doesn't support updating the name of the selected item when it changes.

When you add a key (e.g. "Drawer Key") to a blank keyring ("Keyring"), the item will change name to "Keyring (Drawer Key)". If you then add another key ("Quantify Key") and switch to select that one, it renames to "Keyring (Quantify Key"). Each shift-right-click with it will swap between the names. But when the keyring is added to the morphing tool, the name of the keyring will always stay the same as it was when added, regardless of what key is currently selected or even removed from it.

Conversely, if all keys are added to the keyring after it was added to the morphing tool, the name will always remain just plainly "Keyring" instead.

commented

To be fair, the keyring working is not really any different from the keys working too, individually. This issue is about multiple items canceling each other out, so to say. I'll make a new issue later for the keyring though.

commented

Great to hear that the key ring works! Could you open a new issue for the naming issue? If you got time a few screenshots would help me too! ^^

commented

I'll make a separate report shortly, but I just wanted to show this screenshot:
image

Having the drawer key in the tool doesn't allow adding the quantify key to it as shown. This is still the case even though there now is a keyring. My suggestion to fix this is to add "keyring" to the "whitelisted names" config by default, and not simply "key". This forces the use of the keyring, which still allows the player to have just a single key on it if they want.

Not adding support for multiple items from the same mod should be fine from the perspective of Storage Drawers, now with the benefit of the keyring. As long as the keyring gets default support.

commented

Ohh okay, cool!

commented

I'm planning on doing that! I just didn't even know the ring existed until you mentioned it

commented

I suggested creating it recently, and provided with a design.
Great, thanks!