Legacy repo missing code

Question

Legacy repo missing code

kevinvanrijn opened this issue 7 years ago · 3 comments

kevinvanrijn commented 7 years ago

Hi, I cloned the repo to build a copy that doesn't crash with the latest version of OptiFine.

I've got everything working and building successfully but it looks like the Morph-Beta-0.9.3 changes were never published in this repo.

The master branch appears to be version 0.9.1 with updated mob lists and the legacy1710 branch appears to be version 0.9.2.

Any chance the missing code could be added to this repo?

I realize it's technically no longer supported but I feel there is a difference in "Help me thing broke" and git history missing.

iChun · Answer 1 · 2017-12-22T22:51:18.000Z

Uhhhhhhhh I don't think I even have the code for that anymore. It might be lost in one of the hard drives backups I have. The changelog for it was: Morph – 0.9.3 – Fix hostileMode capping at 4, making option 5 unselectable – Add /morph morph [player name] <entity name> command Nothing too major. Hopefully that's alright? The important bits in previous updates were to redirect the URL for the abilities and that's been done.

…

On 23 Dec 2017 2:33 AM, "Kevin van Rijn" ***@***.***> wrote: Hi, I cloned the repo to build a copy that doesn't crash with the latest version of OptiFine. I've got everything working and building successfully but it looks like the Morph-Beta-0.9.3 changes were never published in this repo. The master branch appears to be version 0.9.1 with updated mob lists and the legacy1710 branch appears to be version 0.9.2. Any chance the missing code could be added to this repo? I realize it's technically no longer supported but I feel there is a difference in "Help me thing broke" and git history missing. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#915>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACMSTDOfj_IvgYSjWFJdesdxr0bbpzwzks5tC9J-gaJpZM4RLLs_> .

kevinvanrijn · Answer 2 · 2017-12-23T00:31:20.000Z

While the changes are nothing essential they're still nice things to have. Even just to have the git history match the release versions.

If you don't mind me decompiling the mod I'll go and figure out how reasonable it even is to decompile Minecraft mods. Comparing 0.9.2 and 0.9.3 should get me the changes which can then be applied to the current code.

If you ever bump into the code again please do add it to the repo.

With that said. I'll leave it up to you if you want to leave this issue open or not.

iChun · Answer 3 · 2017-12-23T02:15:05.000Z

Should be fine. All you gotta do is poke through the config class (or maybe the morph class) and the command class and that should be it.

…

On 23 Dec 2017 11:01 AM, "Kevin van Rijn" ***@***.***> wrote: While the changes are nothing essential they're still nice things to have. Even just to have the git history match the release versions. If you don't mind me decompiling the mod I'll go and figure out how reasonable it even is to decompile Minecraft mods. Comparing 0.9.2 and 0.9.3 *should* get me the changes which can then be applied to the current code. If you ever bump into the code again please do add it to the repo. With that said. I'll leave it up to you if you want to leave this issue open or not. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#915 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACMSTESyj8deTfld2iKD6_N0v4C8ZLlGks5tDEnYgaJpZM4RLLs_> .

Share to