Puddles possibly causing server crash while raining
varencilator opened this issue · 8 comments
According to:
malte0811/FerriteCore#17 (comment)
I noticed it happens when it's raining so I believe it may be the issue. Happened even after I removed Ferritecore and Hydrogen mod.
Could you try setting both the snowStackChance and puddleSpawnRate gamerule to 0 and see if it still crashes?
How do I do that? I don't seem to have a config file. Also, for more info, it didn't seem to always crash the server when it rained, only recently when a player was online and it was raining. Puddles was working totally fine with all the mods for over a week.
Puddles was working totally fine with all the mods for over a week.
That's weird, did you add any new mods after that?
The most recent mod I had added was randompatches but that was 5 days before I started having the problem so it's pretty hard to figure out the issue. I'll try changing the gamerule and seeing what's up.
Thank you very much @malte0811 that explains a lot to me. I'll make sure to get a new version out soon.
I don't think this is a mod interaction: The problematic code section is this. If getSurface returns the position of a "full" snow block (8 layers) you still try to add an additional layer to it, which isn't possible. That would also explain why it only started happening after some time, it would take some time for enough snow to accumulate.
Somewhat related, it would be nice if you could either change the name of the method to indicate what mod it comes from or alternatively move the actual code to a different class and only have a call to that method in the mixin itself. Right now crashes inside that Mixin produce very cryptic stacktraces (see the original issue for an example), where the only way of finding the cause is to search for Mixins into that method calling with on github (and hoping that the mod is actually available there).