Fall Damage on Descent
UnseenAcademical opened this issue · 20 comments
When on an elevator configured with the default 0.2 blocks/tick, if going down, the player will take fall damage.
Getting this issue on 1.2.17a, MC 1.16.1. Multiplayer server, little to no lag. In my case, it seems to only happen when I use an Elevator Monitor to go from the surface (Y 64) to my base at Y 20. Going to the floor above at Y 30 doesn't cause any damage. Maybe just a coincidence, but might be worth checking.
I will be redoing the elevator collision and movement this week, so hopefully this issue gets fixed in the process.
I found the actual issue this time instead of just trying to randomly add extra measures.
It should (hopefully) be fixed now in version 1.2.18.
Just had a chance to retest on version 1.2.20. Not having any issues. Thanks!
This doesn't happen for me.
Does this always happen or just sometimes?
Are you playing on a server or singleplayer, and is there lag when it happens?
Are you using other mods?
Is there something, you think might be causing it?
Intermittently, server, no lag noticeable, plenty of other mods, can't immediately think of anything that would be causing it.
I tried to test today and was unable to replicate since the server reboot this morning. I'll keep an eye on it and see if I can find a common thread when it happens.
For now I will close the issue, if it starts to happen again feel free to reopen
Same issue here. MC 1.12.2, mod version 1.2.11.
https://yurie.thigh-high.club/hm3nu7q5.mp4
Only have this issue on Sponge instance with a lot of mods and plugins running. Can't reproduce in singleplayer, local server with and without Sponge (with Sponge it also kicks for floating too long). It could be related to more server load i guess.
Oh seems like it's not resetting the fall distance and onGround flag, that's also why you normally get kicked for flying. It is weird that it only happens with Sponge servers though.
I fixed the issue with getting kicked for floating.
I can't however replicate the issue with taking damage when the elevator arrives. I suspect this has something to do with one of the plugins or mods.
I can reproduce that on Forge-only server by spawning a lot of villagers so that server starts lagging.
https://yurie.thigh-high.club/y63k05nv.mp4
It is weird that it only happens with Sponge servers though.
Not just Sponge. I just tested on just Forge, it kicks for that as well.
Both with and without Sponge I don't get kicked on a local server when I test it.
Edit: Nevermind, I wasn't on the elevator for long enough.
In 1.2.14, I'm still dying to fall damage. I had it set to 0.4t or higher.
The damage only seems to occur if the player is moving when elevator stops.
1.2.14, 0.2 blocks/t, fall damage even in singleplayer when server is lagging.
https://yurie.thigh-high.club/sig4jdjt.mp4
In version 1.2.14, I canceled all fall damage when on the platform and for 5 seconds after. I now changed it to be 100 ticks instead of 5 seconds.
I also cancel fall damage client side now, since it seems to happen client side before the elevator even arrives on the server. I had no clue fall damage was even handled client side.
I really hope this fixes it.
I have no idea how it happens and why it happens. Different server, stable 20 TPS, pretty powerful hardware (which means it's not related to any slowdowns), no Sponge installed, 1.2.16 (latest version of the mod)
Yet still...
Edit: built a test elevator and did a few runs on it: https://yurie.thigh-high.club/51pfb2v6.mp4