MrCrayfish's Furniture Mod

MrCrayfish's Furniture Mod

88M Downloads

breaking blinds returns oak blinds

SanjivanM opened this issue ยท 8 comments

commented

When breaking blinds of other wood, they drop oak blinds. Possibly metadata stuff when returning the item dropped?

commented

Can confirm, on all blinds in 1.12.2.
xJon/The-1.12.2-Pack#199

commented

Can confirm the bug is still there in 6.3 version for 1.12.2.

commented

The "glitch" starts here, and goes for the next 10 lines of code

Basically, getItemDropped and getPickBlock don't take the variant into account. I'd make a PR, but I don't have time to give it a detailed look

commented

I came to report this as well.

commented

So I downloaded the 1.12.2 version and loaded it onto my workspace, did the usual gradle setup things, but I see no eclipse folder (after doing gradlew setup and eclipse and all that), can anyone confirm, or am I just missing something?

Just had to give the commands some "cooldown" before the next one, I guess...

commented

Alright, someone PM @MrCrayfish to accept this PR (as well as others, I have the built JAR that fixes this issue only)

commented

Great! :) Did you also fix the pick block method right under?

commented

Yep. The code for that was nearly identical, so that really helped. I might take what I've learnt and apply it to a few of my own mods :P