MrCrayfish's Furniture Mod

MrCrayfish's Furniture Mod

88M Downloads

1.12.2-6.3.1 toilet crash

kreezxil opened this issue · 22 comments

commented

Steps to reproduce the behavior:

  1. craft toilet
  2. sit on it

Minecraft:

1.12.2

Forge:

14.23.5.2847

Mod Name:

MrCrayfish's Furniture Mod

Mod Version:

6.3.1-1.12.2

Crash Report:

https://pastebin.com/p2mKuB89

Latest Log:

https://pastebin.com/dXUhPiXT

commented
commented

The problem isn't the keybind itself. The problem is the value assigned to the key.
Since this value is negative, usually an impossible thing, Java can't handle it, so it crashes.
Now I'm gonna test the pack to see the error myself

commented

It's a keybinding problem. When you click on the toilet, it shows the message:
"Press (key) to Fart".
The problem is that the key you set to fart, doesn't have a name to show, so the game crashes.
Or at least, that's what I understood. What key did you set for the fart?

commented
commented

It's different. For now, he is ONLY working on the 1.14.4 version of this mod. And on other small mods like Controllable and Filters.

commented

Sadly, my graphic card isn't good enough to support the pack. So I can't see the problem. If you want, you can ask the player which told you about this problem to record a video in which he shows the key he used and what happens exactly when he sits on the toilet.

commented
commented

Hello, i am not really sure what the key was, and because my pc is in boxes i can't look at the moment. If i am next time at my pc i'll look at it, but i am really sure i have deleted the key because i didn't wanted to sit on a toilet to go around more crashes, if i can help somehow other pls tell me.

commented

Hello, jam325, could you tell us if you tried just once to sit on the toilet, or if you tried to sit a second time or even a third?
Also, were you on the server or in a single player world? Have you tried going in a server or vice versa?

commented

I tried to sit on the toilet multiple times, like 3 or 4 times, with the keybind set to "none" i can normally sit on it

I was on the world of dragons server from kreezxil

commented

Ok thank you. I knew you could sit with the none key, but we have to know if you changed the key or if it was some kind of compatibility problem

commented

@LorenzoMontanoPecoraro are you able to fix this?

commented

Sadly, I can't reproduce the issue, so there isn't much I can do. We should wait for MrCrayfish to see the issue.

commented
commented

That's really bad. In my opinion the toilet is one of the funniest and the most no-sense block in this mod. It's really bad that someone can't use it

commented
commented

You see, it's not that easy. Because for DEFAULT it shouldn't allow a negative value( in this case -96). And then, I'm not some super duper java developer, I'm a person that is slowly learning java trough Minecraft modding. So there isn't anything else I can do. And I'm really sorry to not being able to help. I may try something if I'd know the keybind @jam325 used when his game crashed.

commented

I think it was "F"

commented

Mmh, there is still an issue. I can't reproduce the crash. So, if you can reproduce the crash, record a video of the crash happening, post it here, along with screens of ALL of your keybinds, I may do something about it

commented

Ok, but i can't reproduce it now, if my dad see's that my pc is on, is it dead

commented

Well, I have to sleep, since I've got school tomorrow. Goodbye

commented

OKAY GUYS, I'VE GOT NEWS.
So I wasn't totally right about what I previously said....
I forgot how Java worked for a while. So I'm going to explain for everyone:
the value of the keybinding CAN
BE NEGATIVE, and these are usually used for mouse buttons;
if you go to https://minecraft.gamepedia.com/Key_codes under the "Mouse" section, you can see that the "-96" code HAS a name, but not a description.
So, the crash MAY occure because of this.