MumbleLink

MumbleLink

456k Downloads

TeamSpeak context compat issue

magneticflux- opened this issue ยท 2 comments

commented

I found this TeamSpeak issue with the context field here: https://github.com/magneticflux-/fabric-mumblelink-mod/issues/79

Remember to include this change for Minecraft 1.19 and later instead of sending an empty context: magneticflux-/fabric-mumblelink-mod@540d29a

commented

This would effect this code

protected String generateContext(Minecraft game, int maxLength) {

or the addon could be extended:
https://github.com/zsawyer/MumbleLink/blob/QnD-MC_JNA/mod/src/main/java/zsawyer/mods/mumblelink/addons/pa/es/ExtendedPASupport.java#L60

However we explicitly did set this to empty at some point.
// empty context because the plugin name is already always prepended anyways

I am not happy with this arbitrariness imposed by TeamSpeak.

commented

Note: hardcode context to be "Context" starting with 1.19.x