
[Crash] [Music Triggers 1.18.2 - Fabric] Refuses to start if musictriggers.toml is edited
ShinryuAspect opened this issue ยท 11 comments
I was about to test some edits in the file when Minecraft decided to crash (I was following the wiki, more precisely, this and it crashed just as the trigger was expected to play, I assume). Fun fact, I can delete everything from the .toml file and edit it vie a GUI feature, but, as soon as I exit and launch the game again, the crash happens.
Attached crash file. Anything else you may need, just hit me up and I'll do my best to provide it.
There seems to be an issue with the menu trigger in particular for fabric 1.18.2. Other triggers should still work fine. I will be pushing a fix this weekend
Sure, take your time. I'm happy to see a mod of this kind being developed on Fabric. I used to play a lot with Ambience - Extras and ActualMusic and I was kinda sad about not seeing anything among the lines being developed for the latest versions.
Sure, implying the song name is mainmenu.ogg, the file is as simple as this: https://pastebin.com/Lk4WwA8H (it doesn't let me upload a toml file, so I'm attaching a pastebin).
Ill have to do some testing myself with the 1.18.2 fabric version but Ill push it with the round of fixes for tonight if I find the issue
Ok so I released 5.1 and tested a fairly large config folder without any issues in the 1.18.2 fabric version. You can reopen this if you are still experiencing issues
Looks like its a different crash. This one usually happens when the song in your config does not match the name of a sound file in your folder. What is the name of your sound file and is it in the correct place? You could alternatively send a zip of the entire folder so I can just take a look myself
I renamed the song to be song1 and place it in MusicTriggers/songs/assets/musictriggers/sounds/music
Also, on a side note, if I use the in-game GUI method, I can seem to add the songs and they properly work, until I restart the mod, which then causes this crash.
Also also, it may be mere coincidence. but the one trigger that is causing the crash to me is the "menu" one. I trid to start the game with the "generic" one and it worked, but, as soon as I added the "menu" one, it started to send me that crash. I can add both via the in-game GUI and the "menu" one works, until reset.
EDIT: give me 10 mins or so and I'll upload a .zip containing the config and mods folder, with just FabricAPI and MusicTriggers as I have it set up.
EDIT2: attached the .zip file. As I told you, with that exact setup, it crashes. As soon as I delete the lines regarding the "menu" trigger, it works again. Haven't tested with any other trigger apart from "menu" and "generic", so can't tell if it's specific for that one. Also, if it matters, using fabric-loader-0.13.3-1.18.2. Hit me up if you need anything else.
fabric-music_triggers.zip
Still experiencing the exact same crash as before: Java complaining about an item inside a Map being null when it tries to access it.
I copy-pasted the very first example provided on The Basics page from the wiki (I made sure the .ogg was also called song1, just like in that example) and that same .0gg file is properly being detected, as it was converted to an .ogg from an .mp3 that it was originally (there are no conversion errors either, as de .ogg plays smoothly and without any problem).
Also, it can't be a mod incompatibility, as I've literally removed every single mod from the folder aside from FabricAPI and MusicTriggers.
The contents of my musictriggers.toml (literally, copied from the examples)
crash-2022-04-15_21.03.57-client.txt