
[Forge 1.18.2-5.4-hf] NPE occurring occasionally
Gronglegrowth opened this issue ยท 7 comments
Describe the bug
So far, the game has crashed twice; once while switching from the main menu to the world creation screen, and again when just unpausing the game after a moment. Both crashes mention NullPointerExceptions, caused by this mod.
To Reproduce
Steps to reproduce the behavior: Play the game normally, and occasionally it will crash. I don't yet know the exact causes.
Additional context
I am using the Bliss modpack, version 1.0.1; the included mod version is 5.4-hf. Both crash logs are attached.
crash-2022-05-31_12.28.48-client.txt
crash-2022-05-31_11.57.18-client.txt
Probably the same issue as #41
This type of crash usually happens when the song that tries to play does not have a file attached to it (incorrect or missing file name). It could also be possible that the song wasn't converted properly (you can check by seeing if the music disc for the song is playable). I neither of those are correct, then there could be some weird incompatibility in the modpack that I am unaware of at the moment.
Either way, 6.0 is moving away from the vanilla sound system so these types of crashes won't occur anymore after that gets released
To give more information for those that are interested, the crash comes from this line from 1.18.2 branch and happens because the music that tried to play failed to start playing for some reason, which means that the sound engine did not start tracking it and the source attached to a null sound instance is null.
I expect 6.0 is a big undertaking then; Should we expect a hotfix to fix this or is this a "remove until 6.0" situation?
It's something tied to the vanilla sound system itself, so it can't really be patched so easily with a hotfix. Most of the time the crash is a result of a config error with a mismatched song name though, it's just not very self explanatory. 6.0 should be out within the next few weeks anyways if everything goes well
https://mclo.gs/unlcGPH It is now happening on startup for me.