tinkers kama interaction
Warbringer12 opened this issue ยท 7 comments
Describe the bug
tinkers kama doesn't harvest mystical agriculture crops
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots / Scripts / Logs
Please add your logs and scripts (if applicable).
Versions (please complete the following information):
- Minecraft: 1.18.2
- Forge: 1.18.2-40.1.19
- Cucumber: 1.18.2-5.1.0
- Mystical Agriculture: 1.18.2-5.1.0
will also require
- Tconstruct: 1.18.2-3.5.0.17
- Mantle: 1.18.2-1.9.20
Brief summary so we can look into compatibility: our harvest works by first checking if the block is in one of a set of tags (one for blocks like berry bushes, one for blocks like wheat, and one for blocks like sugar cane). I assume you want the blocks like wheat, which works by using the block's loot table to get a list of drops. If any of the drops are in our seeds tag, that drop is removed and the crop is reverted either using the vanilla method (CropBlock) or by setting age=0 by scanning for a property by that name.
If your crops require more to harvest than reverting to age 0 and dropping, we have an event for more fine-tuned control. We use the event natively to "harvest" pumpkins by turning them into jack-o-lanterns, and to "harvest" bee hives, to give you an idea of the flexibility of the hook.
Since this seems to require integration on my end (which seems a bit unnecessary but I digress), I will add this to agradditions once tinkers comes out for 1.19.
It shouldn't require integration on your end beyond adding your crop to a single tag. If it requires anything more, I highly doubt it works with other right click harvest mods.
@KnightMiner From my experience (as well as my own implementations) crop harvesting is usually handled by just checking if a block is an instance of CropsBlock. When I looked into how Tinkers' does it, it does that but also requires a tag, which is what I was referring to when I said I would need to add an 'integration' on my end.
In my experience, not having a whitelist and relying on instances leads to bugs as soon as someone extends it for a different goal.
Anyways, if you have no plans to fix this for 1.18, I will note to anyone discovering the issue that all it takes is a single tag, so a datapack fixing it would not be hard to do. I'd add the tag myself, but it feels wrong for me to add another mods crops to the minecraft:crops tag (if you have a good reason to not use that tag, there is an alternative tag you can use. In my experience though, everyone uses that tag)
