Disabling Secondary Seed Outputs Doesn't Work [1.20.1]
Carolly opened this issue · 7 comments
Describe the bug
When the config file shows:
#Should crops have a chance of dropping a second seed when harvested?
secondarySeedDrops = false
secondary seed drops are still occurring on every harvest
To Reproduce
Steps to reproduce the behavior:
Set secondarySeedDrops to false and harvest a Mystical Agriculture crop
Expected behavior
A clear and concise description of what you expected to happen.
A second seed does not drop
Screenshots / Scripts / Logs
Please add your logs and scripts (if applicable).
Versions (please complete the following information):
- Minecraft: 1.20.1
- Forge: 47.1.3
- Cucumber: 1.20.1-7.0.3
- Mystical Agriculture: 1.20.1-7.0.4
I just tested and disabling that config definitely seems to work. I only get one seed back every harvest. Are you using a mod to harvest them?
I am having the opposite issue, I have the config set to true and my seeds are on the correct essence farmland but I can't get any more seeds to drop. I am on the latest version of both cucumber and mystical agriculture and there aren't any conflicting mods as the extra seeds still wouldn't drop when all I had were cucumber and mystical agriculture.
@Inverse84 For me, too, on 1.20.1 no additional seeds seem to be dropping, even though I have planted all my seeds on corresponding levels of essence farmland
Having debugged the code a bit, I noticed that there seems to be a rounding issue for the LootContextParams origin vector, causing negative x, y or z coordinates to be off by 1. This means, the mod is actually checking adjacent farmlands instead of the ones directly below. I will provide a PR with a fix in a little bit.
@Carolly are you still experiencing your issue with the latest MA release?