Mystical World

Mystical World

19M Downloads

Part of the key is the same

magcicada opened this issue ยท 6 comments

commented

Part of the key is the same,such sa the keyitem.silver_dust.name is the same as it of Tiny Progressions ,it will cause the translation get errors.I think it should add modid to the key to distinguish,thanks.
2019-08-11 134819
2019-08-11 135010
It will cause the translation of the key to be covered.
2019-08-11_14 00 47
2019-08-11_13 59 59

commented

I'm not really sure how this causes conflict, as they are both powdered silver. Surely the translation would be identical?

commented

This keyitem.silver_dust.name is the same as lightgray glowstone dust of tiny progressions,so the translation will be covered by translation of lightgray glowstone dust.

commented

See also:

The recommended practice is to always add modid into translation key, even if they are referring to items with the same meaning.

commented

I'd suggest that Tiny Progression's naming here is problematic, as ours is literally silver dust and the translation key is the one automatically generated by Minecraft. I'm not sure how much effort it would take for the library to be able to support it, but at the same time I'd be concerned about changing our name when ours is literally silver dust (and the ore dict key is dustSilver).

commented

@3TUSK Sure, but Tiny Progression's silver dust is referring to something else entirely different (grey-coloured glowstone) rather than actual silver dust. I feel like the onus should be on them to change it -- not us.

i.e., they have an item which is not actually silver ground down into a dust called "silver dust". We have an item that is actually silver ground down to a dust called "silver dust".

Also, additionally, @EpicSquid will need to chime in as to how the library can cope with adjusting translation keys because, as far as I'm aware, they're using the auto-generated Minecraft ones.

commented

If Tiny Progressions won't change their translation key, please open a new issue for this.