Mythic Upgrades

Mythic Upgrades

7M Downloads

Incompatability with mod "AdventureZ"

cobaltlol opened this issue · 9 comments

commented

https://pastebin.com/6ydSH8Ry - latest.log, having both AdventureZ or Mythic upgrades crashes the game upon starting but stops crashing when either are removed.

commented

This regression was introduced 2.3.0, and also exists in 2.3.1.

I believe the issue was introduced by 363bd90 or by d8db20a. (though this may be an incorrect assumption) However, since that mixin is only injecting into the HEAD of the method and not overwriting it completely, I believe the compatibility issue may be on their end.

See: Globox1997/AdventureZ#161

commented

Thanks, hopefully this gets fixed by AdventureZ devs.

commented

Do note: I may be incorrect in that assessment that it's an issue with adventurez.

commented

Hello! Yes, it was issue on our side, fixed in #47

commented

good to know

commented

@solonovamax Previously I was overriding PlayerEntity.damage() method, however, I could just mixin here. Now I have done it. Tested in dev environment with latest 1.20.1 AdventureZ, no longer receiving crashes

commented

@solonovamax Previously I was overriding PlayerEntity.damage() method, however, I could just mixin here. Now I have done it. Tested in dev environment with latest 1.20.1 AdventureZ, no longer receiving crashes

Alright, when you publish a new release, I'll give it a test myself (too lazy to build from source rn lol)

commented

fixed

commented

@solonovamax 2.3.2 published, feel free to test :D