Enchant Giver cannot change Mythic effects
itsdinkd opened this issue · 5 comments
latest version of both mods for fabric 1.18.1. it automatically converts back to mending
Any chance on making this optional? The allows players of my modpack AQM2
to easily get mending from a disenchanter mod it uses.
…On Tue, Jan 25, 2022, 4:36 PM Noaaan ***@***.***> wrote:
This is intended behaviour, as I currently have set the replace value to
true in my EnchantGiver config code for my items.
—
Reply to this email directly, view it on GitHub
<#60 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIL5CKA7CPKRFWUD3MNKJEDUX46YHANCNFSM5MTWJ3VA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
This is intended behaviour, as I currently have set the replace value to true in my EnchantGiver config code for my items.
The whole point of EnchantGiver is to unenchanted items to gain abilities from enchantments, not to grant items enchants on craft. This is further reinforced with the fact you can enchant any item with an ability from EnchantGiver. Being able to disenchant these would go against the whole point of this functionality.
I get the purpose of EnchantGiver. It's not something I added into my pack,
as it's a required dependency. Regardless of that, that's why I'd like to
change your mending enchantment to a different enchantment. The whole point
of modpacks is customization and tailoring to the needs of the pack, not
what we think something should be used for. I have to work with what I'm
given with some mods.
So any chance on making it so you do not force settings with enchant giver?
…On Wed, Jan 26, 2022, 6:01 AM Noaaan ***@***.***> wrote:
The whole point of EnchantGiver is to *unenchanted* items to gain
abilities from enchantments, not to grant items enchants on craft. This is
further reinforced with the fact you can enchant any item with an ability
from EnchantGiver. Being able to disenchant these would go against the
whole point of this functionality.
[image: image]
<https://user-images.githubusercontent.com/4163353/151176617-c9443a06-73c5-4e97-82e6-b5afed20ba2e.png>
—
Reply to this email directly, view it on GitHub
<#60 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIL5CKHGNVHNOPL3O7S2RGTUX75DRANCNFSM5MTWJ3VA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>