Nameless Trinkets

Nameless Trinkets

6M Downloads

Request: Curios API Support

Closed this issue ยท 14 comments

commented

Describe your idea

Are you able to add support for Curios API?

In my case I'm currently using Accessories with the Curios Compat Layer because the majority of the mods I have require Curios API, aside from this mod any another that require Accessories. but, as Curios Compat has not updated to match the latest Curios API version, i can't update any mod using the Curios Compat Mod since some are requiring the latest version.

Why is this feature important?

Mainly to allow the mod to be used with varies curios/trinket mods... I understand when the port to NeoForge 1.21.1 was released Curios API was discontinued and Accessories was one of the top go to choices, and prior to that the mod was Curios API based.

I understand if its not possible to support both at the same time, i have zero clue how things work in the backend, and i definitely don't want you to have to create multiple versions of the same mod, just really hoping its something that is possible.

commented

It's something I've been thinking about for a while now.

It's a bit tricky because Curios is still at 1.21.1 and Accesories is already at 1.21.4, meaning if I switch to Curios API, NeoForge would no longer be available for this latest version. Plus, I want the Fabric version. And of course, it's a hassle.

As I mentioned before, I've been thinking about this for a while. And maybe I'll end up with support for both? I have to see if I can simply abstract the code, which would be good because every time I change/fix something in a trinket right now (regarding its effects), I have to change it twice, for Fabric and NeoForge.

If I do this, I can have the code in Common and only then call it. This way I could have two NeoForges at the same time, one with Curios API and the other with Accessories.

I can't confirm that I'll actually do all of this or that it will even work. But you know what I'm thinking. I'll leave this issue open until I decide what to do with it.

commented

Thank you.

I'm not a mod dev, but I work with plenty of application development and management professionally so I completely understand challenge. Thank you again, I appreciate you taking the time to explain it to me.

commented

I'm working on adding Curios API support. It's proving a bit complicated, but for now, I think it's feasible.

commented

great to hear, thank you!

commented

Image

Well, it's working.

It compiles, and some Trinket has worked for me. NeoForge-Accessories still hasn't compiled for me, let alone Fabric, but that's because I haven't modified the code.

It's been faster than I expected, though not easy. I'll check that it at least works outside of DevEnv and maybe upload an Alpha.

commented

I've released an alpha version. I forgot to mention it in a commit.

commented

nice, i'll give it a look when later today.

commented

I came here to ask this very question and seeing this thread has brought joy to my soul.

commented

A quick update on this: Fabric-Accessories, NeoForge-Accessories, and NeoForge-Curios are currently working. I'm finishing implementing all the code I disabled when I created NeoForge-Curios. A beta version will be released soon.

commented

Great, thank you for the update.

commented

A new Beta 2 has been released; apparently, Beta 1 crashed easily. Since I tested it quickly in peaceful mode, I couldn't see the problem.

I need to test the trinkets one by one to make sure they work in all three instances, so if anyone finds any more bugs, I'd appreciate it if you could open an issue.

commented

Definitely, will do!

commented

Beta 3 is out. It only fixes a couple of bugs. I'll be releasing these types of betas as they're reported until I have time to review the trinkets one by one.
I'll keep announcing these betas, even if they're just minor fixes. So everyone knows I'm still working on them.

commented

Version 1.2.0 brings back support for the Curios API, while maintaining Accessories. You'll just need to download the corresponding file. Although this is the stable version, there may be some issues I've missed, so I'd appreciate it if you could report them here on Github

With this, I close this thread. Thank you for your patience. It will be updated to new versions gradually..