Natura

Natura

55M Downloads

Jungles overtaken by Amaranth- the config property for "Amaranth Tree Spawn Rarity" is unused (fix included)

luke-bravenboer opened this issue ยท 0 comments

commented

Description
The config option for "Amaranth Tree Spawn Rarity" is currently unused, causing vanilla jungle biomes to contain a very large amount of Amaranth trees; in some cases, even more than Jungle trees themselves. I'd like to configure this so that they're more of a rarity.

(See for yourself- it's being defined as 'Config.amaranthRarity')

Fix
Line 208 of OverworldTreesGenerator.java should include a reference to Config.amaranthRarity, in the same way that line 195 references Config.willowRarity, or as with any of the other overworld trees.
Line 208 is currently just this:

if (Config.generateAmaranth)

Not only is it not using the config option, but it's not even calling random.nextInt- so it will always spawn the maximum possible amount of amaranth trees.
Here's what the line should presumably be instead:

if (Config.generateAmaranth && random.nextInt(Config.amaranthRarity) == 0)

Affected Version: natura-1.12.2-4.3.2.49 (latest state of the 1.12 branch)


~~~

(I wish there was a simple way to make a small pull request without creating an entire project fork...)