Natural Progression

Natural Progression

229k Downloads

Incompatibility with 1.20.1 Jade

D0CTOR-ZED opened this issue ยท 1 comments

commented

Minecraft version 1.20.1
Forge 47.2.19

When running just Forge, Natural Progression, and Jade for minecraft 1.20.1, looking at a stone block acts as if the player is trying to break the stone block with an unapproved tool. Jade calls getDestroyProgress when determining how to render block breaking progress, which I believe is the trigger for the issue.

As the stone breaking code is similar with the one for wood (was there a third material type?), that is probably affected as well.

I generated a stack trace during the break speed to determine why the event was being triggered.

    at TRANSFORMER/[email protected]/net.minecraftforge.event.ForgeEventFactory.getBreakSpeed(ForgeEventFactory.java:189)
    at TRANSFORMER/[email protected]/net.minecraft.world.entity.player.Player.getDigSpeed(Player.java:721)
    at TRANSFORMER/[email protected]/net.minecraft.world.level.block.state.BlockBehaviour.m_5880_(BlockBehaviour.java:370)
    at TRANSFORMER/[email protected]/net.minecraft.world.level.block.state.BlockBehaviour$BlockStateBase.m_60625_(BlockBehaviour.java:641)
    at TRANSFORMER/[email protected]/snownee.jade.JadeClient.drawBreakingProgress(JadeClient.java:237)
    at TRANSFORMER/[email protected]/snownee.jade.overlay.OverlayRenderer.lambda$renderOverlay$0(OverlayRenderer.java:209)
    at TRANSFORMER/[email protected]/snownee.jade.impl.CallbackContainer.call(CallbackContainer.java:28)
    at TRANSFORMER/[email protected]/snownee.jade.overlay.OverlayRenderer.renderOverlay(OverlayRenderer.java:208)
    at TRANSFORMER/[email protected]/snownee.jade.overlay.OverlayRenderer.renderOverlay478757(OverlayRenderer.java:149)
    at TRANSFORMER/[email protected]/snownee.jade.util.ClientProxy.onRenderTick(ClientProxy.java:163)

Would it be possible for Natural Progression to only trigger when breaking progress is greater than 0?

commented

This has been fixed via 9ac5be3 :)