Nature's Aura

Nature's Aura

31M Downloads

advancement data format changed, causing advancements to get awarded erroneously

esotericist opened this issue ยท 2 comments

commented

in the 1.18 version of nature's aura, simply obtaining an item will award a large number of advancements that should not yet be awarded. for instance:
image

this particular example was done by collecting an iron helmet (which is why suit up is in the list), but it would work with any item. this is due to a change in the json data on the vanilla minecraft side:
"item": "minecraft:polished_granite", to "items": ["minecraft:polished_granite"],

a diff of the changes in the timeframe as described in the history of the minecraft wiki:
https://minecraft.fandom.com/wiki/Advancement/JSON_format?type=revision&diff=1952481&oldid=1908997

the supplementaries dev has already integrated that change in the commit here, if that's helpful (but honestly, as far as i can tell it's just the above change from item entry to items array)
MehVahdJukaar/Supplementaries@e796313

the most obnoxious thing about this is that the old format doesn't produce an obvious error, it just silently fails to be a valid condition.

commented

Wow, that is super annoying. Thanks for the research, though!

commented

i have to credit mehvahdjukaar with actually learning it was a deliberate mojang change. i spent a few hours chasing down "why the hell advancements" last night and it would have taken me a lot longer to realize why without the pointer.