Incompatible with Terrestria mod
Valokki opened this issue ยท 5 comments
What happens
After updating NaturesSpirit to 1.3.0 version, game now crashes when loading world or when trying to create new.
Disabling Terrestria biome terrestria:outback or NaturesSpirit biomes natures_spirit:xeric_plains arid_savanna seems to fix crash
Mods needed to reproduce
- Fabric API [0.91.0+1.20.1]
- TerraBlender [3.0.0.169]
- Terrestria [6.0.13]
- Nature's Spirit [1.3.0.3]
Logs
crash-2023-12-18_11.42.33-server.txt
crash-2023-12-18_11.51.00-server.txt
This is caused by the following features in Arid Savanna (I haven't looked at Xeric Plains):
"minecraft:patch_grass_savanna",
"minecraft:patch_dead_bush_2",
Although the order of these features is undefined in vanilla, I'm not going to be changing Terrestria again. I changed it some time ago -- to the order now conflicting with Nature's Spirit -- in order to be compatible with BYG and William Wythers. I recommend that Nature's Spirit do the same.
Edit: I don't see any obvious issue between Terrestria's Outback and Nature's Spirit Xeric Plains. Are you certain Xeric Plains is involved?
Not completely certain but disabling Xeric Plains fixed loading crash.
There is also natures_spirit:shrubland mentioned in crash log and looks like either disabling shrubland or xeric plains fixes crash, maybe real culprit is shrubland?
I'm not developer or coder so it is possible that I was incorrect about xeric plains causing error.
What you are describing might be a cycle that only directly involves Nature's Spirit biomes. A third biome can sometimes bring such a cycle to light because it uses some of the same features and has a placement that locates it between the other two biomes. Feature order cycles can only occur when the involved biomes are all involved in generation at the same time. I don't see anything in Shrubland that concerns me w.r.t. Terrestria, though.
This is caused by the following features in Arid Savanna (I haven't looked at Xeric Plains): "minecraft:patch_grass_savanna", "minecraft:patch_dead_bush_2",
Although the order of these features is undefined in vanilla, I'm not going to be changing Terrestria again. I changed it some time ago -- to the order now conflicting with Nature's Spirit -- in order to be compatible with BYG and William Wythers. I recommend that Nature's Spirit do the same.
Edit: I don't see any obvious issue between Terrestria's Outback and Nature's Spirit Xeric Plains. Are you certain Xeric Plains is involved?
ill go ahead and make this change throughout the biomes
I keep disabling biomes and new pop up
Caused by: java.lang.IllegalStateException: Feature order cycle found, involved sources: [Reference{ResourceKey[minecraft:worldgen/biome / terrestria:outback]=net.minecraft.class_1959@48cf1f14}, Reference{ResourceKey[minecraft:worldgen/biome / natures_spirit:arid_savanna]=net.minecraft.class_1959@20a04eb}]
alright lets disable arid savanna
Caused by: java.lang.IllegalStateException: Feature order cycle found, involved sources: [Reference{ResourceKey[minecraft:worldgen/biome / terrestria:outback]=net.minecraft.class_1959@36334c15}, Reference{ResourceKey[minecraft:worldgen/biome / natures_spirit:shrubland]=net.minecraft.class_1959@2c6e19b7}, Reference{ResourceKey[minecraft:worldgen/biome / natures_spirit:xeric_plains]=net.minecraft.class_1959@1ebcf98e}]
lets disable those two
Caused by: java.lang.IllegalStateException: Feature order cycle found, involved sources: [Reference{ResourceKey[minecraft:worldgen/biome / terralith:arid_highlands]=net.minecraft.class_1959@6b0ebfc6}, Reference{ResourceKey[minecraft:worldgen/biome / natures_spirit:tundra]=net.minecraft.class_1959@4c880369}, Reference{ResourceKey[minecraft:worldgen/biome / natures_spirit:prairie]=net.minecraft.class_1959@34b06a0a}, Reference{ResourceKey[minecraft:worldgen/biome / natures_spirit:bamboo_wetlands]=net.minecraft.class_1959@51613df2}, Reference{ResourceKey[minecraft:worldgen/biome / natures_spirit:wooded_drylands]=net.minecraft.class_1959@25a2aef9}]
now I am stuck because idk which one is tundra