Nbt Crafting (Fabric)

Nbt Crafting (Fabric)

630k Downloads

[1.15pre] fisticuffs with libcd

Yoghurt4C opened this issue ยท 4 comments

commented

doing a /reload breaks all of libcd's pseudotag ingredients when nbtcrafting is present.

reproduction:
-get libcd and nbtcrafting
-get a datapack and make a data/namespace/tweakers/whatever.js file
-inside the file, place the following:

var sample1=RecipeTweaker.makeIngredient("fuzzy","minecraft:diamond","minecraft:bedrock");
RecipeTweaker.addShaped([
	[sample1]],
	TweakerUtils.createItemStack("minecraft:dirt",1));

-save and runClient
-observe as the recipe works
-do /reload
-observe

commented

from me having both mods installed and using them for my datapacks. my loot script hasn't broken with NBT crafting installed.

commented

The bug report should probably include the imports for reproduction as they are needed for the libcd recipe to work in the first place:
var RecipeTweaker = libcd.require("libcd.recipe.RecipeTweaker"); var TweakerUtils = libcd.require("libcd.util.TweakerUtils");;

Anyway, with nbt crafting 2.0 alpha 10 and libcd 2.2.2 on version 1.15.2, the libcd recipe works before and after a reload, so this bug is fixed.

commented

Nice thanks ๐Ÿ˜

commented

@Yoghurt4C
Can you please verify that this bug still exists?
Otherwise I'm gonna consider this bug as gone ๐Ÿ™‚