Nbt Crafting (Fabric)

Version
1.6.4
Describe the bug
This inject is extremely invasive and specifically breaks cardinal components and everyone else who is trying to do anything with items.

nbt-crafting/src/main/java/de/siphalor/nbtcrafting/mixin/MixinItemStack.java

Lines 35 to 39 in 5d7a45a

    
           @Inject(method = "areTagsEqual", at = @At("HEAD"), cancellable = true) 
        
           private static void areTagsEqual(ItemStack stack1, ItemStack stack2, CallbackInfoReturnable<Boolean> callbackInfoReturnable) { 
        
           	if (!stack1.hasTag() && !stack2.hasTag()) 
        
           		callbackInfoReturnable.setReturnValue(true); 
        
           }

To Reproduce
use cardinal components.
Expected behavior
Cardinal components'/vanilla minecraft's correct item equality methods to be called, but they never do as you cancel them.

fixed in 2.0.3 - somehow this issue wasn't closed

	@Inject(method = "areTagsEqual", at = @At("HEAD"), cancellable = true)
	private static void areTagsEqual(ItemStack stack1, ItemStack stack2, CallbackInfoReturnable<Boolean> callbackInfoReturnable) {
	if (!stack1.hasTag() && !stack2.hasTag())
	callbackInfoReturnable.setReturnValue(true);
	}

Share to