Nbt Crafting (Fabric)

Nbt Crafting (Fabric)

630k Downloads

[bug] Client sync issue where NBT tags are not immediately copied to a remainder for duplicate recipe ingredients

sleepy-evelyn opened this issue ยท 3 comments

commented

Version
Minecraft version 1.16.5,
NBT Crafting version 2.0.6+1.16.4

Describe the bug
Although the NBT data is copied to the remainder item left in the crafting grid it isn't displayed to the user on the client on a dedicated server until the user moves out of the crafting grid

To Reproduce

  1. Create an item recipe that passes NBT data onto the remainder from another item
  2. Hover over the item in the crafting grid that is left after the recipe is completed (the remainder) and the output crafted item is taken. The NBT data shouldn't be copied
  3. Move the item from the crafting grid into your inventory. The NBT data should now update on the client for the item

Expected behavior
The NBT data should be immediately visible on the remainder from the client

Log
No log, instead just a recipe.

{
  "type": "minecraft:crafting_shapeless",
  "ingredients": [
    {
      "item": "territorial:key",
      "data":{
        "deny": {
          "display": {
            "Name": ""
          }
        }
      }
    },
    {
      "item": "territorial:key",
      "remainder": {
        "item": "territorial:key",
        "data": {
          "$": "$ i1"
        }
      },
      "data": {
        "require": {
          "display": {
            "Name": ""
          }
        }
      }
    }
  ],
  "result":
  {
    "item": "territorial:key",
    "data": {
      "$": "$ i1"
    }
  }
}

Is possible I mucked something up here since i'm fairly new to this. Idea is nbt data is copied from one key to another by placing 1 blank key with no custom NBT data and one key with NBT data included such as the keys name and tooltip

commented

Think after looking this is a duplicate of #57 & #47
Guess for this case it can be fixed by just changing the order of ingredients though :P

commented

After re-arranging the items in the crafting grid so the item with NBT data is the first ingredient I still seem to get this issue

commented

Re-writing this issue lol edited it too many times