Nbt Crafting (Fabric)

Nbt Crafting (Fabric)

Mods
630k Downloads

[bug] custom brewing recipes do not play sound

maityyy opened this issue ยท 1 comments

commented

MC 1.18.2, NBT Crafting 1.18:2.1.0+

When a brewing stand has brewed a potion, the SoundEvents.BLOCK_BREWING_STAND_BREW sound is played. However, this does not happen for custom potions, like:

{
    "type": "nbtcrafting:brewing",
    "base": { "potion": "minecraft:awkward" },
    "ingredient": [
        { "item": "minecraft:slime_ball" },
        { "item": "minecraft:rabbit_foot" }
    ],
    "result": {
        "item": "minecraft:potion",
        "data": {
            "Potion": "minecraft:water",
            "CustomPotionEffects": [
                {
                    "Id": 8,
                    "Duration": 4800
                }
            ],
            "display": { "Name": "{\"translate\":\"item.minecraft.potion\"}" }
        }
    }
}

This line is missing here. It is in the vanilla implementation of this method, but NBT Crafting seems to have forgotten to add it.

world.syncWorldEvent(WorldEvents.BREWING_STAND_BREWS, pos, 0);
commented

image