Nbt Crafting (Fabric)

Nbt Crafting (Fabric)

Mods
630k Downloads

[bug] Custom Names are not inherited in brewing outputs

Darkiceflame opened this issue ยท 1 comments

commented

Version
MC 1.18.2, NBTC 2.1.2
Describe the bug
The outputs of recipes using a custom display name do not inherit the name defined in the recipe, regardless of what the output item is.

To Reproduce
An example recipe:

{
	"type": "nbtcrafting:brewing",
	"base": {
		"potion": "minecraft:regeneration"
	},
	"ingredient": {
		"item": "minecraft:stick"
	},
	"result": {
		"item": "minecraft:stick",
		"data": {
			"display": {
				"Name": {
					"text": "Potion Of Bug Reporting",
					"italic": false
				}
			}
		}
	}
}

Expected behavior
The resulting item should have the custom name defined in the recipe

Log
No noticeable errors generated in the log

23:02:57.936
Preparing Data Pack injection.
23:02:57.939
Loaded folder Data Pack from REDACTED\config\openloader\data\main.
23:02:57.939
Successfully injected 1/1 packs from REDACTED\config\openloader\data.
23:02:57.940
[REDACTED: Reloading!]
23:02:58.873
[Nbt Crafting] Syncing advanced recipe data to 1 players
23:02:58.873
[Nbt Crafting] Syncing to player REDACTED
23:02:58.874
Reloading Plugin Manager [REIPlugin] stage [START], registered 7 plugins: ReiRecipeLookup [wthit], DefaultRuntimePlugin [roughlyenoughitems], DefaultClientRuntimePlugin [roughlyenoughitems], REIPlugin [nbtcrafting], FabricFluidAPISupportPlugin, DefaultPlugin [roughlyenoughitems], DefaultClientPlugin [roughlyenoughitems]
23:02:58.876
Reloaded Plugin Manager [REIPlugin] with 2 entry types, 5 item comparators, 0 fluid comparators and 2 fluid support providers in 3ms.
commented

Hi,

the issue is in this case not in Nbt Crafting but in your JSON/NBT :)
The display.Name tag must be a string of the text data, so you would need to nest the compound in quotes.

Luckily, Nbt Crafting still has you covered, so you can use the following sugar:

{
	"type": "nbtcrafting:brewing",
	"base": {
		"potion": "minecraft:regeneration"
	},
	"ingredient": {
		"item": "minecraft:stick"
	},
	"result": {
		"item": "minecraft:stick",
		"data": {
			"display": {
				"Name": {
					"text": "Potion Of Bug Reporting",
					"italic": false,
					"nbtcrafting:stringify": true
				}
			}
		}
	}
}