Green icon is not shown on legacy servers
Madis0 opened this issue ยท 3 comments
Modloader
Fabric
Minecraft Version
1.19.1
Modloader Version
API 0.58.5/Loader 0.14.8
No Chat Reports Version
1.19.1-1.8.2
Modpack Info
No response
The latest.log File
irrelevant
Bug Description
Green checkmark is not displayed on servers that clearly use a protocol older than 1.19 (759). I thought this was obvious that those servers should always be green...
Steps to Reproduce
- Join a legacy server such as Hypixel
- Check the chat icon
Other Information
In case you want to test and are not sure about a server's protocol, I have a tool that can check this. Note that this is not 100% accurate on hub-based servers, because the hub itself may be older than the other worlds. I'm pretty sure the game itself can get the info per-world more accurately.
I've asked how ViaFabric and multiconnect get the real protocol and the answer was by pinging them with protocol -1. If the server would respond back with some unknown value, e.g. -1 as well, they would join with the client version.
So I guess the logic here would be to
- ping the servers first
- cache the value
- make sure the value is in a reasonable range (1-758 perhaps)
- attempt to join
- user types a chat message to get the status (1.19.3)
- if other states are valid (e.g. doesn't request signatures somehow), set the state to green.
Hopefully it could work together with mods like ViaFabric and multiconnect. Maybe NCR could ping them right at the start while the player is trying to connect?
