All of the UI pertaining to the new Chat Encryption feature are cut off on most common display resolutions, including 1920x1080 and 3456x2160.
akemin-dayo opened this issue · 10 comments
Environment
Modloader: quilt-loader 0.17.4
Minecraft Version: 1.19.2, 1.19.1
No Chat Reports Version: 1.13.0
Bug Description
All of the UI pertaining to the new Chat Encryption feature are cut off on most common display resolutions, including 1920x1080 and 3456x2160.
This includes both "About Encryption" and "Encryption Settings".
It would probably be a good idea to decrease the amount of padding between each line, or something like that.
Screenshots ("About Encryption")
1920x1017@4x (Windowed mode on Windows)
1920x1080@4x (Fullscreen)
3456x1974@8x (Windowed mode on macOS)
3456x2160@8x (Fullscreen)
Screenshots ("Encryption Settings")
1920x1017@4x (Windowed mode on Windows)
1920x1080@4x (Fullscreen)
3456x1974@8x (Windowed mode on macOS)
3456x2160@8x (Fullscreen)
I do ;P
Myself aside, most people probably don't change the default UI scaling setting from "0" (Auto) anyway, which means Minecraft will always default to the largest UI scale possible.
Can confirm, the issue is now fully fixed as of eafe2c8 / 1.13.5.
Hmn, I'm noticing some odd behaviour even after 907df11.
If the UI scaling option is left at the default of 0 (Auto) for 3456x1974, it seems that specifically the "Encryption Settings" view does not go into "huge UI" mode. The "About Encryption" view appears to be unaffected, at least in my testing.
If you explicitly set a UI scale of 7 or 8 in the settings, then everything behaves as expected.
This doesn't make any sense, both screens use absolutely identical calculation for whether or not they should go into huge mode. What NCR version did you test this with, and are you sure that auto is actually equal to 7 or 8?
What NCR version did you test this with
I've tested this with NCR 1.13.4 and 1.13.2.
are you sure that auto is actually equal to 7 or 8?
I have not programmatically verified this, but "Auto" does at least appear visually identical to both 7 and 8. (※ When the Unicode font is enabled, all odd-number UI scales become equivalent to their +1 value.)
both screens use absolutely identical calculation for whether or not they should go into huge mode
I was also thinking this was the case (given hugeGUI() in the code), but I… don't have any other explanation for what I'm seeing.
I'll try adding some debug logging for hugeGUI() later when I have time to see what's going on.
Screenshots
"About Encryption" displaying correctly at 0 UI scale
"Encryption Settings" somehow not going into huge UI mode at 0 UI scale
UI scale of 0 (Auto)
UI scale explicitly set to 8
… and now "Encryption Settings" works correctly when set explicitly to 8 (or 7 — the scaling is identical)
Really weird. The only explanation I see is if screen height somehow is not calculated correctly in the case of settings screen, but I have no idea why it would go wrong with that screen specifically and not the other one.
Ahhhhh I got it. I goes into huge mode, I just didn't check it correctly where line height is calculated...