No Chat Reports

No Chat Reports

43M Downloads

Literal string that could be converted to a translation key

James103 opened this issue ยท 3 comments

commented

handler.disconnect(Component.literal("You do not have No Chat Reports, and this server is configured to require it on client!"));

The above code, present in commit ae263f1, uses a literal string to show the kick reason, which is that the mod is not installed on the client but is required there by the server. This string could use some translations, which should make the mod a bit more accessible to international players.

commented

In order to use translatable component the client has to have translation for it. The only way we can supply that translation is by having our mod installed on client, in which case player will not get kicked with this reason in the first place.

commented

I'm not sure if people would want that, but you could add an option to change the message's language in the (serverside) config or even allow to configure a custom message through the config, like plugins often do.
It would be useful for servers that generally translate as much as they can into a specific language.

commented

I'm not sure if people would want that, but you could add an option to change the message's language in the (serverside) config or even allow to configure a custom message through the config, like plugins often do.

Make a separate issue on that, I will take care of it later.