Noisium

Noisium

15M Downloads

Incompatibility with Mine Cells

ZiLenTz opened this issue ยท 7 comments

commented

Hi, I've been using this mod for a while with no issue and it works great.
However, teleporting to one of Mine Cells dimensions, Promenade of The Condemned or minecells:promenade, will result in disconnecting the player and crashing the server.

To be specific, that dimension can't be generated with Noisium.
Also, based on a crash log, it seems like the issue is related to NoiseChunkGenerator from Noisium.
Right now I have to play without Noisium since removing it solved the issue.

Crash Log: https://mclo.gs/QFFDEI0

Minecraft 1.20.1
Fabric Loader 0.15.7
Noisium 2.0.1
Mine Cells 1.7.2

Portal to Promenade of The Condemned (minecells:promenade)
2024-04-07_00 36 44

commented

Reverting Noisium back to v1.0.2 seems to solve the issue for me.

commented

Hi ZiLenTz, thanks for the report. I'll look into this issue!

commented

Hey, Mine Cells dev here, I'd be happy to help try and figure out this issue and fix it if the fault is on my end ๐Ÿ˜…

I believe the issue might be related to one of my custom density functions, where I sample a noise in a not-so-conventional way. (not the best at writing that type of thing, so I'd appreciate any suggestions for improvements in the code, and a possible way to fix this crash!)

commented

@mim1q Hi mim1q, thanks for reaching out. I haven't figured out why it occurs on my end (when it doesn't with vanilla + MineCells).
I'll do some investigating and write back.

commented

Really appreciate both of your responses!

Thanks for your hard work!

commented

I found where the issue happens. The chunk section locking goes out of bounds when accessing the arrays of chunk sections in noisium$populateNoiseInject. For some reason it's looping over more chunk sections than it's allocating to the array.
Might be an issue on my end, will take a further look

commented

@ZiLenTz @mim1q Should be fixed in v2.0.3.