Not Enough Items 1.8.+

Not Enough Items 1.8.+

16M Downloads

[Forge 2708]NullPointerException

Pythonic-Rainbow opened this issue ยท 12 comments

commented

In case anyone needs to know, the problem isn't on Thamuic JEI. I removed it and still crashes

commented

Tested in 2708. Same result.

commented

Going to need a full log, there is literally no stack trace in that crash report.

commented
commented

Getting the same crash.
https://pastebin.com/XJgHuXUe

commented
commented

Tested without NEI, loades successfully.

commented

@covers1624, this is related to / another incident of the underlying problem that caused #161. It's a multi-mod incompatibility issue relating to Astral Sorcery + many other mods- however, it doesn't occur with simply NEI & AS installed. This particular incident is caused by IC2, I've just replicated it myself, here is the relevant stack trace:

net.minecraftforge.fml.common.LoaderExceptionModCrash: Caught exception from Not Enough Items (nei)
Caused by: java.lang.NullPointerException
    at ic2.core.init.BlocksItems$1.getItemStackLimit(BlocksItems.java:430)
    at net.minecraft.item.ItemStack.getMaxStackSize(ItemStack.java:248)
    at hellfirepvp.astralsorcery.common.enchantment.amulet.EnchantmentUpgradeHelper.isItemBlacklisted(EnchantmentUpgradeHelper.java:176)
    at hellfirepvp.astralsorcery.common.enchantment.amulet.PlayerAmuletHandler.attachAmuletItemCapability(PlayerAmuletHandler.java:38)
    at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_153_PlayerAmuletHandler_attachAmuletItemCapability_AttachCapabilitiesEvent.invoke(.dynamic)
    at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)
    at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:182)
    at net.minecraftforge.event.ForgeEventFactory.gatherCapabilities(ForgeEventFactory.java:658)
    at net.minecraftforge.event.ForgeEventFactory.gatherCapabilities(ForgeEventFactory.java:640)
    at net.minecraft.item.ItemStack.forgeInit(ItemStack.java:1216)
    at net.minecraft.item.ItemStack.<init>(ItemStack.java:112)
    at net.minecraft.item.ItemStack.<init>(ItemStack.java:98)
    at codechicken.lib.inventory.InventoryUtils.newItemStack(InventoryUtils.java:60)
    at codechicken.nei.util.ItemStackMap.wildcard(ItemStackMap.java:224)
    at codechicken.nei.util.ItemStackSet.with(ItemStackSet.java:23)
    at codechicken.nei.init.NEIInitialization.loadModSubsets(NEIInitialization.java:329)
    at codechicken.nei.init.NEIInitialization.bootNEI(NEIInitialization.java:72)

(Crash log: https://paste.dimdev.org/goxacahado.mccrash)

Instances of this bug been springing up all over the place since Astral Sorcery's 1.9.0 update in various shapes and forms, not just NPEs- they added some code that's checking all items for enchantments or something:

I first experienced the bug with Mekanism myself & the crash logs seemed to point to NEI being the culprit, but I discovered that removing NEI didn't fix the issue. Mekanism has released a fix for their issue- Mekanism 9.4.12.348.

However- I'm still experiencing the issue myself with both Unique Crops (v1.12-0.1.52) & IC2 (v2.8.84-ex112), and have heard that it also affects the Erebus at least. In these instances, removing NEI does fix the crash- so NEI may still be a suspect.
(Here's the crash log that I get from AS 1.9 + NEI + Unique Crops, btw: https://paste.dimdev.org/jozoyozoni.mccrash)

Correct me if I'm wrong, but from what I can tell, it's likely relating to this part, as it sounds like some mods might be unprepared to provide wildcard items for whatever AS is doing:

...
    at codechicken.nei.util.ItemStackMap.wildcard(ItemStackMap.java:224)
    at codechicken.nei.util.ItemStackSet.with(ItemStackSet.java:23)
    at codechicken.nei.init.NEIInitialization.loadModSubsets(NEIInitialization.java:329)
...

@Pythonic-Rainbow can we please change the title to 'Astral Sorcery 1.9.0 incompatibility' or something a bit more descriptive?

commented

In that case, duplicate of #161
There is nothing i can do, i create an itemstack and their event handler explodes.

commented

@covers1624 fair enough, just trying to help, as removing NEI fixes the issue and all...

Opened a ticket with Unique Crops: bafomdad/uniquecrops#10

@Pythonic-Rainbow you'll need to open an issue with IC2 for your problem.

commented

IC2 says the problem is resolved in 2.2.85 @covers1624