NotEnoughItems Unofficial 1.7.10

NotEnoughItems Unofficial 1.7.10

436k Downloads

[Feature Request] Add Search history item panel

Discreater opened this issue ยท 7 comments

commented

It will be useful to have a search history item panel.

Feature Request

  1. Add a new item panel (or part of BookmarkPanel or ItemPanel) part of to store the search history.
  2. Add the item to history panel every time user query usage or recipe.
  3. The history should be an queue. But when an existing item is readded, move it to the beginning.
  4. Add the configuration options such as max history size or turn off the history.

NEI Easy Search

In fact, there was already a mod (NEI Easy Search) that did this in Chinese community .
image
But this mod only provides two lines of history and cannot be configured.
And more importantly, it crashed with NEI-GTNH 2.0. Although I have tried to modify the code to make it work on the NEI 2.0.x and 2.1.x. It still crashed with NEI 2.2.
This mod uses a lot of reflection, to call or override private methods of ItemPanel. Maintaining this mod is difficult (at least for me).

commented

It will be useful to have a search history item panel.

Feature Request

  1. Add a new item panel (or part of or ) part of to store the search history.BookmarkPanel``ItemPanel
  2. Add the item to history panel every time user query usage or recipe.
  3. The history should be an queue. But when an existing item is readded, move it to the beginning.
  4. Add the configuration options such as max history size or turn off the history.

NEI Easy Search

In fact, there was already a mod (NEI Easy Search) that did this in Chinese community . image But this mod only provides two lines of history and cannot be configured. And more importantly, it crashed with NEI-GTNH 2.0. Although I have tried to modify the code to make it work on the NEI 2.0.x and 2.1.x. It still crashed with NEI 2.2. This mod uses a lot of reflection, to call or override private methods of . Maintaining this mod is difficult (at least for me).ItemPanel

Maybe you can try NEI Utilities

commented

@vfyjxf Nice work!

commented

@vfyjxf Nice work!

About the max history size and turn off the history setting, I will add them in recent days.

commented

But Items must be align center

With mod Without Mod
image image
commented

@slprime Actually, I'm not quite sure what went wrong.

With Mod Without Mod NEI Version
image image 2.2.10
commented

@vfyjxf Please use super.setGridSize(mLeft, mTop, w, h) in this overwritten method.
image

In this PR, I've added another computed property to this method
https://github.com/GTNewHorizons/NotEnoughItems/pull/240/files#diff-b21c3be9562bd070e4fe3ec5befb4a01bf23f6dbed66fd13b4f9a4625326fd6fR105

commented

OK, I got it.