NotEnoughItems Unofficial 1.7.10

NotEnoughItems Unofficial 1.7.10

436k Downloads

Suggestion: allow GT tools, motors, etc. to be used when populating crafting grid

MauveCloud opened this issue · 7 comments

commented

Shift+clicking the "?" icon works to populate the crafting grid with materials for crafting a motor (or a number of other GT items, as long as they use "simple" ingredients), but not when crafting something with the motor, or anything that requires GT tools, like rotors. As far as I can tell, that is caused by the last condition in this line:

return stack1.getItem() == stack2.getItem() && stack1.getItemDamage() == stack2.getItemDamage() && ItemStack.areItemStackTagsEqual(stack2, stack1);

GT Tools use NBT tags to keep track of the materials they were made from as well as durability, so they don't "stack" with the tools shown in the recipe, and I think items like motors, conveyor belts, pumps, and such use tags to allow them to work in the disassembler, but I'm unclear on why the tags need to be strictly checked like this before moving items to the crafting table. I tried making a local build with the strict NBT tag matching commented out, and with what little testing I've done so far, it seems to work, though idk if that would break something else.

commented

That would be an awesome feature, as it stands currently only forestry craftingtables and AE2 are able to work with GT tools

commented

the removal of the disassembly NBT should partially adress this for the GT components.

commented

the removal of the disassembly NBT should partially adress this for the GT components.

But that is still something that has to be done in the source code, right? It's nothing we can do on user side?

commented

Checking item class against a cached version of GT tool or item classes was suggested long ago. (Removes dependency against GT and keeps NBT matching for everything else)

Just nobody ever implemented it. 🤷🏻‍♀️

commented
commented

Cool, thanks for tracking this down. I don't think we'd want to globally comment out the strict NBT tag matching, but we can make a version that ignores NBT, or select NBT tags, for GT items.

commented

This should be in beta 15 or so. Please test it out and let me know if you find any issues with it; it worked in my limited testing.