Handler for the mutagen producer from gendustry does not have a correctly localized name

Question

Handler for the mutagen producer from gendustry does not have a correctly localized name

Prometheus0000 opened this issue 4 years ago · 8 comments

Prometheus0000 commented 4 years ago

GTNH-Afx237v7 commented 4 years ago

:D

mitchej123 · Answer 1 · 2021-04-11T05:53:02.000Z

Not sure if this is NEI's fault... but will look more into it

mitchej123 · Answer 2 · 2021-04-11T06:17:49.000Z

Bug in gendustry. It references the translation key tile.gendustry.mutagen.producer.name but the key in the file is tile.gendustry.mutagen_producer.name

Prometheus0000 · Answer 3 · 2021-04-11T06:30:01.000Z

https://github.com/GTNewHorizons/gendustry/commits/mc1710/src/net/bdew/gendustry/machines/mproducer/GuiMutagenProducer.scala

Are we using a build that has this? It looks correct in code and the lang file?

mitchej123 · Answer 4 · 2021-04-11T06:32:04.000Z

https://github.com/GTNewHorizons/gendustry/blob/mc1710/resources/assets/gendustry/lang/en_US.lang#L3

https://github.com/GTNewHorizons/gendustry/blob/mc1710/src/net/bdew/gendustry/nei/MutagenProducerHandler.scala#L67

Prometheus0000 · Answer 5 · 2021-04-11T06:34:05.000Z

Made a PR to fix.

Prometheus0000 · Answer 6 · 2021-04-16T12:31:41.000Z

It was fixed in gendustry.

GTNH-Afx237v7 · Answer 7 · 2021-04-16T12:23:18.000Z

Still exists in 2.1.1 (grabbed from Jenkins earlier today)

Share to