NotEnoughResources

NotEnoughResources

7M Downloads

Hello!

Lanse505 opened this issue ยท 12 comments

commented

I got Sent here by the mod dev of Ancient Warfare 2 after i have looked up this crash.

http://pastebin.com/hPwq5kR7

This is the original post:
P3pp3rF1y/AncientWarfare2#191

commented

@Lanse505 What is the version you are using make sure to get the latest build from the Jenkins

commented

we are running 77

commented

@Lanse505 What item are you trying to lookup? (Mod and version of it to if applicable)

commented

Let me ask as soon as I come back to a computer I'm at my in-laws

commented

This is how it happens:

"Hi,

When i right click the engineering AW station with a stack of oak wood planks it crashes the server and all items inside the crafting grid of the engineering station are "lost" (simply gone after relog).

If I use a single oak wood plank it does not crash."

Its using Ancient Warfare v.2.3.78-BETA-MC1.7.10

When we posted this on the Ancient Warfare Devs Github he promptly pointed us here :P

commented

Similar issue exists in NEIAdvSeedHandler. I'm just setting up a workspace so I can test locally and avoid wasting your time with a million and one pull requests.

commented

Struggling to set up my workspace, it's been too long since I did this. Anyway; pushed the change, will test in the morning if necessary.

commented

@way2muchnoise - not your finest work my friend :P

commented

The problem is a reference to a nonexistent vararg in NEIPlantHandler.loadUsageRecipes. I've chucked a pull request at you which should fix it, but do ignore me if I've misunderstood.

EDIT: What I meant is; I'm sure this is part of a wider issue, (why that method is being called in the first place) but this pull serves as a hotfix. And you should really be doing that check for varargs anyway 'cause you never know when some cowboy's gonna come in and abuse your code. Xx.

commented

looks good, would appreciate you testing when jenkins has built it

commented

@hilburn Keep calm and finish restrictions

commented

Tested build #79 and am now unable to reproduce, I'm calling this fixed.