Entity rendering bug in Fogger mod.
GrandeMalum opened this issue ยท 6 comments
Describe the bug
The mod seems to be incompatible with the Fogger mod in 2 different ways. The first one is: If the fog radius is set to low number, all entities will render very wacky and almost glow in the dark because of the fog overlay.
Here is the link for the mod: https://www.curseforge.com/minecraft/mc-mods/fogger
To Reproduce
Steps to reproduce the behavior of the first issue:
- Install Optifine, Fogger and Nothorium together.
- Configure Fogger with my specific method:
# Configuration file
default-fog {
# Procentage value of where the fog ends relative to the full visible distance
D:DefaultWhereTheFogEnds=48F
# Procentage value of where the fog starts relative to the full visible distance
D:DefaultWhereTheFogStarts=0F
}
dependant-fog {
# Assign created Fog Definitions to specific minecraft biome and world's y-axis. Note that defining over 1000 biomes will become a bottleneck. To make the y-axis work define them by y-axis in descending order. Soon it will be fixed.
S:FogDefinitionMaps <
minecraft:ocean 0.0 temperate-water-1
minecraft:desert 0.0 warm-desert-1
minecraft:extreme_hills 0.0 temperate-hills-1
minecraft:river 74.0 default
minecraft:river 46.0 temperate-river-1
minecraft:frozen_river 74.0 default
minecraft:frozen_river 46.0 cold-river-1
minecraft:ice_flats 0.0 cold-fields-1
minecraft:ice_mountains 0.0 cold-hills-1
minecraft:mushroom_island 0.0 mushroom-island
minecraft:mushroom_island_shore 0.0 mushroom-island
minecraft:desert_hills 0.0 temperate-hills-1
minecraft:forest_hills 0.0 temperate-hills-1
minecraft:taiga_hills 0.0 temperate-hills-1
minecraft:smaller_extreme_hills 0.0 temperate-hills-1
minecraft:stone_beach 0.0 temperate-hills-1
minecraft:cold_beach 0.0 cold-fields-1
minecraft:taiga_cold 0.0 cold-fields-1
minecraft:taiga_cold_hills 0.0 temperate-hills-1
minecraft:redwood_taiga_hills 0.0 temperate-hills-1
minecraft:extreme_hills_with_trees 0.0 temperate-hills-1
minecraft:wooded_badlands_plateau 0.0 temperate-hills-1
minecraft:cold_ocean 0.0 cold-water-1
minecraft:deep_cold_ocean 0.0 cold-water-1
minecraft:deep_frozen_ocean 0.0 cold-water-1
minecraft:mutated_desert 0.0 warm-desert-2
minecraft:mutated_extreme_hills 0.0 temperate-hills-1
minecraft:mutated_ice_flats 0.0 cold-fields-1
minecraft:mutated_birch_forest_hills 0.0 temperate-hills-1
minecraft:mutated_taiga_cold 0.0 cold-fields-1
minecraft:mutated_redwood_taiga_hills 0.0 temperate-hills-1
minecraft:mutated_extreme_hills_with_trees 0.0 temperate-hills-1
minecraft:mutated_mesa_rock 0.0 temperate-hills-1
minecraft:mutated_mesa_clear_rock 0.0 temperate-hills-1
minecraft:bamboo_jungle_hills 0.0 temperate-hills-1
biomesoplenty:oasis 0.0 warm-forest-1
biomesoplenty:steppe 0.0 temperate-hills-1
biomesoplenty:alps_foothills 0.0 cold-hills-1
biomesoplenty:bayou 0.0 warm-swamp-1
biomesoplenty:mountain 0.0 cold-hills-2
biomesoplenty:overgrown_cliffs 0.0 temperate-hills-1
biomesoplenty:highland 0.0 temperate-hills-1
biomesoplenty:marsh 0.0 warm-swamp-1
biomesoplenty:wetland 0.0 warm-swamp-2
biomesoplenty:mystic_grove 0.0 temperate-hills-1
biomesoplenty:cold_desert 0.0 cold-fields-1
biomesoplenty:mountain_foothills 0.0 cold-hills-1
biomesoplenty:coral_reef 0.0 warm-water-1
biomesoplenty:orchard 0.0 temperate-fields-1
biomesoplenty:snowy_tundra 0.0 cold-fields-1
biomesoplenty:alps 0.0 cold-hills-4
biomesoplenty:lush_desert 0.0 warm-forest-1
biomesoplenty:mangrove 0.0 mangrove
biomesoplenty:boreal_forest 0.0 cold-forest-1
biomesoplenty:snowy_forest 0.0 cold-forest-3
biomesoplenty:glacier 0.0 cold-hills-3
biomesoplenty:prairie 0.0 temperate-hills-1
biomesoplenty:snowy_coniferous_forest 0.0 cold-fields-1
biomesoplenty:tundra 0.0 cold-forest-2
biomesoplenty:origin_island 0.0 temperate-hills-1
biomesoplenty:gravel_beach 0.0 cold-beach-1
biomesoplenty:origin_beach 0.0 temperate-hills-1
biomesoplenty:rainforest 0.0 warm-forest-1
>
# Define or use exsisting fog references to use them in FogMapDefinitions List.
S:FogDefinitions <
warm-forest-1 0.1 0.85
warm-desert-1 0.05 0.75
warm-desert-2 0.1 0.8
warm-water-1 0.15 0.95
warm-swamp-1 0.1 0.75
warm-swamp-2 0.1 0.65
temperate-fields-1 0.15 1.0
temperate-desert-1 0.1 0.85
temperate-hills-1 0.05 0.95
temperate-river-1 0.05 0.6
temperate-water-1 0.05 0.85
cold-fields-1 0.05 0.65
cold-forest-1 0.05 0.85
cold-forest-2 0.05 0.75
cold-forest-3 0.05 0.55
cold-hills-1 0.05 0.65
cold-hills-2 0.05 0.8
cold-hills-3 0.05 0.75
cold-hills-4 0.05 0.85
cold-river-1 0.05 0.55
cold-water-1 0.1 0.7
cold-beach-1 0.1 0.75
mushroom-island 0.2 0.95
mangrove 0.05 0.75
sample-ramp 0.49 0.5
sample-constant 100.0 200.0
>
}
general {
# Set it to true to make fog rendering independant from view distance. Remember to change fog start, end values as they're no longer in percents. '2F' is a distance of two blocks.
B:IsFogConstant=true
# Set it to true to simplify Fog rendering and apply single rule to all the biomes.
B:IsFogGlobal=true
}
- Generate a world and spawn any entity in the dark area at day time.
- See the issue.
Versions
Nothirium: 0.1.6
RenderLib: 1.1.0
Forge: 14.23.5.2860
Minecraft: 1.12.2
Other mods (necessary to reproduce the bug): Optifine (HD U G5) and Fogger (1.1.2.0)
Hardware
CPU: Intel(R) Core(TM) i7-9700F
RAM: 32768MB
GPU: NVIDIA GeForce RTX 3090
VRAM: 24348MB
Please create separate issues if you are having multiple problems. Also please make some screenshots of how things should look like and how they are looking like.
Nothirium uses hermite interpolation and the distance to camera to calculate the fog strength (similar to how it works in newer versions) when rendering chunks.
Entities and block entities use linear interpolation and depth value to calculate the fog strength which causes them to look a bit different.
This means Nothirium is working as intended here.
In the future I might add a config option to change how the fog strength is calculated when rendering chunks or I might try to change entity rendering to use the same fog model that is used for chunk rendering.