NuclearCraft

NuclearCraft

31M Downloads

He/N Collector Crash when other He/N Fluids Exist

sandalle opened this issue ยท 19 comments

commented

Similar to #123 , I get a server crash a few seconds after placing a Helium Collector. No other machines or pipes are yet connected to it.

Crash report:
crash-2017-09-26_09.16.32-server.txt

Minecraft: 1.11.2
Forge Mod Loader: 1.11.2-13.20.1.2476
NuclearCraft: 2.4b--1.11.2
Modpack: https://minecraft.curseforge.com/projects/nst-unofficial-exploration

commented

Ok, I have an idea - perhaps the GC Helium/Nitrogen is being registered and the NC ones are not, so when te collector tries to generate the NC variety, it crashes... worth a try :P

commented

Ok, I've tested with GC, GregTech and Rockhounding Chem installed and neither of the collectors are crashing the game :)

Will just keep this open while we wait to see if the crash disappears for you too.

commented

NC 2.6 is now released - hopefully the crash has gone...

commented

Gonna close this as there have been no reports of this happening since the update that supposedly fixed it.

commented

Might have found my mistake.

commented

I think I made a mistake in the Tank code, where I accidentally referred to a method parameter instead of the actual properties of the tank. Hopefully the latest version (2.5) fixes the issue :)

commented

Helium Collector still crashes a few seconds after placement (no pipes or other machines attached) with 2.5. :) I just tried a Nitrogen Collector and it has the same issue.

Helium Collector crash-report: crash-2017-09-29_21.57.01-server.txt
Nitrogen Collector crash-report: crash-2017-09-29_22.06.46-server.txt

Minecraft: 1.11.2
Forge Mod Loader: 1.11.2-13.20.1.2476
NuclearCraft: 2.5--1.11.2
Modpack: https://minecraft.curseforge.com/projects/nst-unofficial-exploration

commented

Ok, if this doesn't work, then I'm stumped for now :P

commented

I'll try again tomorrow (at work now and family night out tonight), thank you for the quick responses @turbodiesel4598 ;)

commented

Still crashes with NuclearCraft-2.5YetAnotherCrashFixAttemptPlsWorkOkThx5million+1--1.11.2 :'(
crash-2017-10-01_07.50.22-server.txt

Did you try with my modpack or a different one? Maybe it's a mod conflict messing up the fluids?

I also tried a SSP brand new world and got a crash:
crash-2017-10-01_07.55.53-server.txt

commented

It's possible, although unexpected - I would have thought Forge could deal with multiple fluids of the same name - I'll go over to their forums and ask about - there are a lot of people there that know a lot more about stuff like that than me.

While I do that, could you check that the mod actually runs fine without GC-Planets or whatever mods add their own helium/nitrogen? If it works, then this is either a GC-NC incompatibility or a Forge issue.

commented

Apparently there is a nullPointer error here, but I have no clue why. I'm even doing a null check... I will continue to search for a solution, but this is bizarre...

commented
commented

No dice yet, still crashes shortly after placing a Helium Collector with 2.5fluidCrashFixAttemptNo5Million (nice name ;)): crash-2017-09-30_09.33.23-server.txt

commented

Could it be the NBT data?

at nc.tile.NCTile.func_189515_b(NCTile.java:41)
at nc.tile.NCTile.func_189518_D_(NCTile.java:64)

Or we're getting a fluid that doesn't exist here?

at nc.fluid.Tank.getFluidName(Tank.java:41)

I've never seriously programmed in Java, so am not much help, sorry. :/

commented

It is yes, and being read incorrectly at the line in changeFluid - the reason I'm confused is because I would expect the null check to just stop the helium collector running, not crash the game. The reason this is tricky is because for some reason, it's not crashing mine :P

commented

Maybe it's the combination of mods (e.g. UniDict combining common metals, I don't think it does fluids; or perhaps GalactiCraft)?

Here's what I see for Helium in fml-server-latest.log

[09:35:51] [Server thread/INFO] [nuclearcraft/nuclearcraft]: Registered block helium_collector
[09:35:51] [Server thread/INFO] [nuclearcraft/nuclearcraft]: Registered fluid fluid_helium3
[09:35:51] [Server thread/INFO] [nuclearcraft/nuclearcraft]: Registered fluid fluid_helium
[09:35:51] [Server thread/INFO] [nuclearcraft/nuclearcraft]: Registered fluid fluid_liquidhelium
[09:36:31] [Server thread/DEBUG] [FML/]: Fixed minecraft:blocks id mismatch nuclearcraft:fluid_helium: 2566 (init) -> 2212 (map).
[09:36:31] [Server thread/DEBUG] [FML/]: Fixed minecraft:blocks id mismatch moreplanets:helium_gas: 2134 (init) -> 3122 (map).
[09:36:31] [Server thread/DEBUG] [FML/]: Fixed minecraft:blocks id mismatch nuclearcraft:helium_collector: 2556 (init) -> 2204 (map).
[09:36:31] [Server thread/DEBUG] [FML/]: Fixed minecraft:blocks id mismatch nuclearcraft:fluid_helium3: 2565 (init) -> 2211 (map).
[09:36:31] [Server thread/DEBUG] [FML/]: Fixed minecraft:blocks id mismatch nuclearcraft:fluid_liquidhelium: 2568 (init) -> 2214 (map).
[09:36:31] [Server thread/DEBUG] [FML/]: Fixed minecraft:items id mismatch nuclearcraft:fluid_helium: 7938 (init) -> 7321 (map).
[09:36:31] [Server thread/DEBUG] [FML/]: Fixed minecraft:items id mismatch moreplanets:helium_gas: 6972 (init) -> 9799 (map).
[09:36:31] [Server thread/DEBUG] [FML/]: Fixed minecraft:items id mismatch nuclearcraft:fluid_helium3: 7937 (init) -> 7320 (map).
[09:36:31] [Server thread/DEBUG] [FML/]: Fixed minecraft:items id mismatch nuclearcraft:fluid_liquidhelium: 7940 (init) -> 7323 (map).
[09:36:31] [Server thread/DEBUG] [FML/]: Fixed minecraft:items id mismatch moreplanets:helium_gas_bucket: 7086 (init) -> 9848 (map).
[09:36:31] [Server thread/DEBUG] [FML/]: Fixed minecraft:items id mismatch nuclearcraft:helium_collector: 7928 (init) -> 7313 (map).
[09:36:32] [Server thread/DEBUG] [FML/]: The fluid nuclearcraft:helium3 has been selected as the default fluid for helium3
[09:36:32] [Server thread/DEBUG] [FML/]: The fluid nuclearcraft:liquidhelium has been selected as the default fluid for liquidhelium
[09:36:32] [Server thread/DEBUG] [FML/]: The fluid moreplanets:helium_gas has been selected as the default fluid for helium_gas
[09:36:32] [Server thread/DEBUG] [FML/]: The fluid galacticraftplanets:helium has been selected as the default fluid for helium

And for Nitrogen

[09:35:51] [Server thread/INFO] [nuclearcraft/nuclearcraft]: Registered block nitrogen_collector
[09:35:51] [Server thread/INFO] [nuclearcraft/nuclearcraft]: Registered fluid fluid_nitrogen
[09:36:31] [Server thread/INFO] [FML/]: Found a missing id from the world advancedrocketry:nitrogenfluid
[09:36:31] [Server thread/DEBUG] [FML/]: Fixed minecraft:blocks id mismatch nuclearcraft:fluid_nitrogen: 2576 (init) -> 3254 (map).
[09:36:31] [Server thread/DEBUG] [FML/]: Fixed minecraft:blocks id mismatch nuclearcraft:nitrogen_collector: 2559 (init) -> 3262 (map).
[09:36:31] [Server thread/DEBUG] [FML/]: Fixed minecraft:items id mismatch nuclearcraft:fluid_nitrogen: 7948 (init) -> 9920 (map).
[09:36:31] [Server thread/DEBUG] [FML/]: Fixed minecraft:items id mismatch nuclearcraft:nitrogen_collector: 7931 (init) -> 9905 (map).
[09:36:32] [Server thread/DEBUG] [FML/]: The fluid galacticraftplanets:nitrogen has been selected as the default fluid for nitrogen
[09:36:32] [Server thread/DEBUG] [FML/]: The fluid galacticraftplanets:liquidnitrogen has been selected as the default fluid for liquidnitrogen

Are you trying with my NST Exploration modpack (which doesn't have all the latest updates I'm testing at home) or your own?

commented

Removing both GalactiCraft and More Planets (GalactiCraft add-on) let's the Helium and Nitrogen Collectors work and collect their elements with no crash. Re-adding just GalactiCraft seems to cause both the Helium and Nitrogen Collectors to cause the crash when they attempt to collect their element.

commented

It's likely not specific to GC - I am experiencing a Nitrogen Collector crash similar to this, and I have Rockhounding:Chemistry mod which has its own Nitrogen fluid.